mirror of
https://review.coreboot.org/flashrom.git
synced 2025-07-05 15:50:41 +02:00
flashrom_tester: partial_lock: Use WriteProtectState cache
partial_lock test was bypassing the WriteProtectState cache of the software write protect by directly calling env.cmd.wp_range. It was also unnesesarily disabling software WP. Fix those issues and more clearly document what the test is doing and expecting. BUG=b:244663741 BRANCH=None TEST=flashrom_tester --libflashrom host Change-Id: Ic3f89ff5d22e74e4e6c94e755b936e58cb27182d Signed-off-by: Evan Benn <evanbenn@chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/69418 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:

committed by
Edward O'Callaghan

parent
4c8572f103
commit
8528ea0845
@ -246,6 +246,24 @@ impl<'a> WriteProtectState<'a> {
|
||||
}
|
||||
}
|
||||
|
||||
// Set software write protect with a custom range
|
||||
pub fn set_range(&mut self, range: (i64, i64), enable: bool) -> Result<&mut Self, String> {
|
||||
info!("set_range request={}, current={}", enable, self.current.sw);
|
||||
self.cmd
|
||||
.wp_range(range, enable)
|
||||
.map_err(|e| e.to_string())?;
|
||||
let actual_state = Self::get_sw(self.cmd).map_err(|e| e.to_string())?;
|
||||
if actual_state != enable {
|
||||
Err(format!(
|
||||
"set_range request={}, real={}",
|
||||
enable, actual_state
|
||||
))
|
||||
} else {
|
||||
self.current.sw = enable;
|
||||
Ok(self)
|
||||
}
|
||||
}
|
||||
|
||||
/// Set the hardware write protect if supported and check that the state is as expected.
|
||||
pub fn set_hw(&mut self, enable: bool) -> Result<&mut Self, String> {
|
||||
info!("set_hw request={}, current={}", enable, self.current.hw);
|
||||
|
Reference in New Issue
Block a user