openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-30 16:33:41 +02:00
Code Issues Releases Wiki Activity

tests: Add workaround to allow tests mock fileno on FreeBSD

Browse Source 
fileno can be a function and a macro in FreeBSD, depending on whether
the environment in multi-threaded or single-threaded. For single
thread, macro is used. Macro is expanded into a inline code which
accesses private field of file descriptor. This is impossible to
mock in tests.

Pretending that environment is multi-threaded makes fileno function
to be called instead of a macro. Function can be mocked for tests.

BUG=b:237606255
TEST=ninja test
tests pass on two environments:
1) FreeBSD 13.1-RELEASE-p2 GENERIC amd64
2) Debian 5.17.11 x86_64 GNU/Linux

Change-Id: I3789ea9107a4cf8033cf59bb96d3c82aa58de026
TICKET: https://ticket.coreboot.org/issues/411
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67312
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
This commit is contained in:
Anastasia Klimchuk 2022-09-02 17:30:00 +10:00
parent 50ea017af6
commit 869f3f7b2c
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/tests.c
View File

@ -370,6 +370,17 @@ int main(int argc, char *argv[])
{ {
int ret = 0; int ret = 0;
#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
/*
* Pretending to be a multithreaded environment so that `fileno`
* is called as a function (and not as a macro).
* fileno macro in FreeBSD is expanded into inline access of
* private field of file descriptor, which is impossible to mock.
* Calling fileno as a function allows the test to mock it.
*/
__isthreaded = 1;
#endif
if (argc > 1) if (argc > 1)
cmocka_set_test_filter(argv[1]); cmocka_set_test_filter(argv[1]);