openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 14:33:18 +02:00
Code Issues Releases Wiki Activity

Use shutdown callback mechanism to shutdown programmers

Browse Source 
This patch attempts to resolve some programmer shutdown ordering issues
by having the programmer init functions register shutdown callbacks explicitly
wherever it makes most sense. Before, assumptions were made that could lead to
the internal programmer's state changing before the external programmer could be
shut down properly. Now, each programmer cleans up after itself and (hopefully)
performs each operation in the correct order.

As a side-effect, this patch gives us a better usage model for reverse
operations such as rpci_* and rmmio_*. In the long-run, this should make
reversing the initialization process easier to understand, less tedious, and
less error-prone.

In short, this patch does the following:
- Registers a shutdown callback during initialization for each programmer.
- Kills the .shutdown function pointer from programmer_entry struct. Also,
  make most shutdown functions static.
- Adds a few minor clean-ups and corrections (e.g. missing physunmap() calls).

TODO: Remove forward declaration of serprog_shutdown() (added to simplify diff)

Corresponding to flashrom svn r1338.

Signed-off-by: David Hendricks <dhendrix@google.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
This commit is contained in:
David Hendricks
2011-06-14 01:35:36 +00:00
committed by David Hendricks
parent 9d9a104233
commit 8bb2021d77
24 changed files with 284 additions and 242 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
dediprog.c
View File

@ -536,6 +536,25 @@ static const struct spi_programmer spi_programmer_dediprog = {
.write_256 = dediprog_spi_write_256,
};
static int dediprog_shutdown(void *data)
{
msg_pspew("%s\n", __func__);
/* URB 28. Command Set SPI Voltage to 0. */
if (dediprog_set_spi_voltage(0x0))
return 1;
if (usb_release_interface(dediprog_handle, 0)) {
msg_perr("Could not release USB interface!\n");
return 1;
}
if (usb_close(dediprog_handle)) {
msg_perr("Could not close USB device!\n");
return 1;
}
return 0;
}
/* URB numbers refer to the first log ever captured. */
int dediprog_init(void)
{
@ -587,6 +606,9 @@ int dediprog_init(void)
}
dediprog_endpoint = 2;
if (register_shutdown(dediprog_shutdown, NULL))
return 1;
dediprog_set_leds(PASS_ON|BUSY_ON|ERROR_ON);
/* URB 6. Command A. */
@ -681,22 +703,3 @@ static int dediprog_do_stuff(void)
return 0;
}
#endif
int dediprog_shutdown(void)
{
msg_pspew("%s\n", __func__);
/* URB 28. Command Set SPI Voltage to 0. */
if (dediprog_set_spi_voltage(0x0))
return 1;
if (usb_release_interface(dediprog_handle, 0)) {
msg_perr("Could not release USB interface!\n");
return 1;
}
if (usb_close(dediprog_handle)) {
msg_perr("Could not close USB device!\n");
return 1;
}
return 0;
}