openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

libflashrom: Allow NULL-pointer argument in flashrom_flash_release()

Browse Source 
free() allows NULL and it makes error paths easier to handle when one
just needs to write `free(x);` without needing to care if `x` was
allocated already. Let's follow this rule in flashrom_flash_release().
flashrom_layout_release() already checks for NULL.

Change-Id: Id119c2e4f3aa1b11313059f11aac73c3e583185c
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62340
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nikolai Artemiev <nartemiev@google.com>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
This commit is contained in:
Nico Huber 2022-02-24 18:17:40 +01:00
parent 60005a88ea
commit 8d50fad443
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libflashrom.c
View File

@ -361,6 +361,9 @@ size_t flashrom_flash_getsize(const struct flashrom_flashctx *const flashctx)
*/ */
void flashrom_flash_release(struct flashrom_flashctx *const flashctx) void flashrom_flash_release(struct flashrom_flashctx *const flashctx)
{ {
if (!flashctx)
return;
flashrom_layout_release(flashctx->default_layout); flashrom_layout_release(flashctx->default_layout);
free(flashctx->chip); free(flashctx->chip);
free(flashctx); free(flashctx);