openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 22:43:17 +02:00
Code Issues Releases Wiki Activity

programmer: Smoothen register_opaque_master() API

Browse Source 
It was impossible to register a const struct opaque_master that would
point to dynamically allocated `data`. Fix that so that we won't
have to create more mutable globals.

BUG=b:185191942
TEST=builds

Change-Id: Id3adb4cf04ae04dbe87ddb96f30871cb5f7c8ff0
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54170
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Anastasia Klimchuk
2021-05-13 12:28:47 +10:00
committed by Edward O'Callaghan
parent 6a5db26e68
commit 9309bed290
5 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
opaque.c
View File

@ -46,7 +46,7 @@ int erase_opaque(struct flashctx *flash, unsigned int blockaddr, unsigned int bl
return flash->mst->opaque.erase(flash, blockaddr, blocklen);
}
int register_opaque_master(const struct opaque_master *mst)
int register_opaque_master(const struct opaque_master *mst, void *data)
{
struct registered_master rmst = {0};
@ -58,5 +58,7 @@ int register_opaque_master(const struct opaque_master *mst)
}
rmst.buses_supported = BUS_PROG;
rmst.opaque = *mst;
if (data)
rmst.opaque.data = data;
return register_master(&rmst);
}