openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-11-14 03:30:41 +01:00
Code Issues Releases Wiki Activity

raiden_debug_spi.c: Enables USB retry for invalid write count

Browse Source 
Enables the USB SPI transfer retry mechanism when the error code
USB_SPI_WRITE_COUNT_INVALID is returned. This error code can
indicate a recoverable USB transfer failure.

BUG=b:153887087
BRANCH=none
TEST=Manual testing of ServoMicro and Flashrom when performing
    reads, writes, and verification of the EC firmware on Nami.
TEST=Modified ServoMicro to randomly corrupt USB packets when
    reading the packet length to replicate bad packets and the
    verify recovery is successful.

Change-Id: I9e6b2ccec0b06aab0d6920f1bddf108058e5d6b1
Signed-off-by: Brian J. Nemec <bnemec@chromium.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/41152
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Brian J. Nemec
2020-05-06 15:25:58 -07:00
committed by Edward O'Callaghan
parent a5cbe43761
commit 93bfafc0ec
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
raiden_debug_spi.c
View File

@@ -188,8 +188,12 @@ typedef struct {
static bool retry_recovery(int error_code) static bool retry_recovery(int error_code)
{ {
if (error_code < 0x10000) { if (error_code < 0x10000) {
/* Handle error codes returned from the device. */ /*
if (USB_SPI_WRITE_COUNT_INVALID <= error_code && * Handle error codes returned from the device. USB_SPI_TIMEOUT,
* USB_SPI_BUSY, and USB_SPI_WRITE_COUNT_INVALID have been observed
* during transfer errors to the device and can be recovered.
*/
if (USB_SPI_READ_COUNT_INVALID <= error_code &&
error_code <= USB_SPI_DISABLED) { error_code <= USB_SPI_DISABLED) {
return false; return false;
} }