From 95424a2b972415a75c080f0f356dcddd49261904 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Thu, 12 Oct 2023 14:25:10 +0200 Subject: [PATCH] ich_descriptors: Fix table printing The code uses "%-4s" to print the master names and thus assumes that all names have 4 characters or less. Convert "unknown" to "DevE", short for Device Expansion in order to properly display the table. Test: Run flashrom -p internal -VV Change-Id: I0d10e2771c7a27c1a73ed53a33e68a04eb9e1e00 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/flashrom/+/78301 Reviewed-by: Anastasia Klimchuk Tested-by: build bot (Jenkins) --- ich_descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ich_descriptors.c b/ich_descriptors.c index 4b440ed7b..c3d062e12 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -491,7 +491,7 @@ void prettyprint_ich_descriptor_master(const enum ich_chipset cs, const struct i cs == CHIPSET_600_SERIES_ALDER_POINT || cs == CHIPSET_JASPER_LAKE || cs == CHIPSET_METEOR_LAKE) { const char *const master_names[] = { - "BIOS", "ME", "GbE", "unknown", "EC", + "BIOS", "ME", "GbE", "DevE", "EC", }; if (nm > (ssize_t)ARRAY_SIZE(master_names)) {