1
0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 14:11:15 +02:00

tests: Add unit test to run init/shutdown for linux_spi.c

The current implementation tests a particular path of the init
procedure. There are two ways for it to succeed: reading the buffer
size from sysfs and the fallback to getpagesize(). This test does
the latter (fallback to getpagesize).

Extract from meson-logs/testlog.txt for new test:

[ RUN      ] linux_spi_init_and_shutdown_test_success
Testing programmer_init for programmer=25 ...
__wrap_open64 is called
__wrap_ioctl is called
__wrap_ioctl is called
__wrap_ioctl is called
__wrap_fopen64 is called
... programmer_init for programmer=25 successful
Testing programmer_shutdown for programmer=25 ...
... programmer_shutdown for programmer=25 successful
[       OK ] linux_spi_init_and_shutdown_test_success

BUG=b:181803212
TEST=builds and ninja test

Change-Id: I4911fbb6f04371283f0e62d2196bdd691a227584
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/52498
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Anastasia Klimchuk
2021-04-23 15:47:03 +10:00
committed by Nico Huber
parent cffaac1e0f
commit 98534e717b
4 changed files with 62 additions and 0 deletions

View File

@ -35,3 +35,14 @@ void dummy_init_and_shutdown_test_success(void **state)
{ {
run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi");
} }
void linux_spi_init_and_shutdown_test_success(void **state)
{
/*
* Current implementation tests a particular path of the init procedure.
* There are two ways for it to succeed: reading the buffer size from sysfs
* and the fallback to getpagesize(). This test does the latter (fallback to
* getpagesize).
*/
run_lifecycle(state, PROGRAMMER_LINUX_SPI, "dev=/dev/null");
}

View File

@ -25,6 +25,13 @@ mocks = [
'-Wl,--wrap=physunmap', '-Wl,--wrap=physunmap',
'-Wl,--wrap=physmap', '-Wl,--wrap=physmap',
'-Wl,--wrap=spi_send_command', '-Wl,--wrap=spi_send_command',
'-Wl,--wrap=sio_write',
'-Wl,--wrap=sio_read',
'-Wl,--wrap=open',
'-Wl,--wrap=open64',
'-Wl,--wrap=ioctl',
'-Wl,--wrap=fopen',
'-Wl,--wrap=fopen64',
'-Wl,--gc-sections', '-Wl,--gc-sections',
] ]

View File

@ -17,6 +17,7 @@
#include "tests.h" #include "tests.h"
#include <stdio.h> #include <stdio.h>
#include <stdint.h>
/* redefinitions/wrapping */ /* redefinitions/wrapping */
#define LOG_ME printf("%s is called\n", __func__) #define LOG_ME printf("%s is called\n", __func__)
@ -32,6 +33,47 @@ void *__wrap_physmap(const char *descr, uintptr_t phys_addr, size_t len)
return NULL; return NULL;
} }
void __wrap_sio_write(uint16_t port, uint8_t reg, uint8_t data)
{
LOG_ME;
}
uint8_t __wrap_sio_read(uint16_t port, uint8_t reg)
{
LOG_ME;
return (uint8_t)mock();
}
int __wrap_open(const char *pathname, int flags)
{
LOG_ME;
return 2021;
}
int __wrap_open64(const char *pathname, int flags)
{
LOG_ME;
return 2021;
}
int __wrap_ioctl(int fd, unsigned long int request, ...)
{
LOG_ME;
return 2021;
}
FILE *__wrap_fopen(const char *pathname, const char *mode)
{
LOG_ME;
return NULL;
}
FILE *__wrap_fopen64(const char *pathname, const char *mode)
{
LOG_ME;
return NULL;
}
int main(void) int main(void)
{ {
int ret = 0; int ret = 0;
@ -70,6 +112,7 @@ int main(void)
const struct CMUnitTest init_shutdown_tests[] = { const struct CMUnitTest init_shutdown_tests[] = {
cmocka_unit_test(dummy_init_and_shutdown_test_success), cmocka_unit_test(dummy_init_and_shutdown_test_success),
cmocka_unit_test(linux_spi_init_and_shutdown_test_success),
}; };
ret |= cmocka_run_group_tests_name("init_shutdown.c tests", init_shutdown_tests, NULL, NULL); ret |= cmocka_run_group_tests_name("init_shutdown.c tests", init_shutdown_tests, NULL, NULL);

View File

@ -42,5 +42,6 @@ void probe_spi_st95_test_success(void **state); /* spi95.c */
/* init_shutdown.c */ /* init_shutdown.c */
void dummy_init_and_shutdown_test_success(void **state); void dummy_init_and_shutdown_test_success(void **state);
void linux_spi_init_and_shutdown_test_success(void **state);
#endif /* TESTS_H */ #endif /* TESTS_H */