openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 14:33:18 +02:00
Code Issues Releases Wiki Activity

4BA: Flashrom integration for the 4-bytes addressing extensions

Browse Source 
This patch integrates code of the previous patch into Flashrom's code.
All the integrations is around 3 functions spi_nbyte_read, spi_nbyte_program
and spi_byte_program. After this patch then are not static and can be called
by their pointers saved in flashchips array. Also I added to flashrom.c some
code to switch a chip to 4-bytes addressing mode. And one error message is
corrected in spi.c because it's not suitable for 32-bit addresses.

Patched files
-------------
flash.h
+ added set of 4-bytes address functions to flashchip structure definition

flashrom.c
+ added switch to 4-bytes addressing more for chips which support it

serprog.c
+ added 4-bytes addressing spi_nbyte_read call to serprog_spi_read

spi.c
+ fixed flash chip size check in spi_chip_read

spi25.c
+ added 4-bytes addressing spi_nbyte_read call to spi_read_chunked
+ added 4-bytes addressing spi_nbyte_program call to spi_write_chunked
+ added 4-bytes addressing spi_byte_program call to spi_chip_write_1

Conflicts:
	serprog.c

Change-Id: Ib051cfc93bd4aa7580519e0e6206d025f3ca8049
Signed-off-by: Boris Baykov <dev@borisbaykov.com>, Russia, Jan 2014
[clg: ported from
      https://www.flashrom.org/pipermail/flashrom/2015-January/013205.html ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-on: https://review.coreboot.org/20505
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Boris Baykov
2016-06-11 18:29:00 +02:00
committed by Nico Huber
parent b1f88360fc
commit 9912718de1
4 changed files with 47 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
flashrom.c
View File

@ -2223,6 +2223,29 @@ int prepare_flash_access(struct flashctx *const flash,
if (flash->chip->unlock)
flash->chip->unlock(flash);
/* Switching to 4-Bytes Addressing mode if flash chip supports it */
if(flash->chip->feature_bits & FEATURE_4BA_SUPPORT) {
/* Do not switch if chip is already in 4-bytes addressing mode */
if (flash->chip->feature_bits & FEATURE_4BA_ONLY) {
msg_cdbg("Flash chip is already in 4-bytes addressing mode.\n");
}
/* Go to 4-Bytes Addressing mode */
else {
if (!flash->chip->four_bytes_addr_funcs.enter_4ba) {
msg_cerr("No function for Enter 4-bytes addressing mode for this flash chip.\n"
"Please report to flashrom@flashrom.org\n");
return 1;
}
if(flash->chip->four_bytes_addr_funcs.enter_4ba(flash)) {
msg_cerr("Switching to 4-bytes addressing mode failed!\n");
return 1;
}
msg_cdbg("Switched to 4-bytes addressing mode.\n");
}
}
return 0;
}