From 9a570318bbb816c6f6587b64d82c986678703495 Mon Sep 17 00:00:00 2001 From: Anastasia Klimchuk Date: Fri, 24 Nov 2023 19:16:18 +1100 Subject: [PATCH] docs: Add guideline about Gerrit display names If none of "Full name" or "Display name" is set for a Gerrit account, code reviews emails are sent from "Name of user not set" instead of a user name. It is worth clarifying explicitly in the docs. Change-Id: I69b6f5c1c56a2798dd156582cb5fa246b2396ab3 Signed-off-by: Anastasia Klimchuk Reviewed-on: https://review.coreboot.org/c/flashrom/+/79250 Tested-by: build bot (Jenkins) Reviewed-by: Peter Marheine Reviewed-by: Stanislav Ponomarev --- doc/dev_guide/development_guide.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index 60c562576..247a31aac 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -183,6 +183,8 @@ Creating an account #. Add an e-mail address so that Gerrit can send notifications to you about your patch. #. Upload an SSH public key, or click the button to generate an HTTPS password. +#. After account created, set either "Full name" or "Display name", it is used by Gerrit + for code review emails. .. _pushing-a-patch: