openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-10-31 05:10:41 +01:00
Code Issues Releases Wiki Activity

cli_classic.c: Be consistent with pointer types

Browse Source 
With `i586-pc-msdosdjgpp-gcc (GCC) 12.2.0`, `uint32_t` is defined as
`long unsigned int`, which is not the same as `unsigned int`. As the
`flashrom_layout_get_region_range()` function is part of libflashrom
API, adjust `cli_classic.c` instead to avoid type mismatches.

Original-Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/69451
Original-Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Original-Reviewed-by: Evan Benn <evanbenn@google.com>
Original-Reviewed-by: Nikolai Artemiev <nartemiev@google.com>
Original-Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

Change-Id: Ie8f5bc0d9296f7c6b8f8a351b53052f5fe86b09d
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/69995
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
This commit is contained in:
Angel Pons
2022-11-11 21:55:26 +01:00
committed by Felix Singer
parent 00635b0da2
commit a415a5d996
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cli_classic.c
View File

@@ -126,7 +126,7 @@ static bool check_file(FILE *file)
return true; return true;
} }
static int parse_wp_range(uint32_t *start, uint32_t *len) static int parse_wp_range(unsigned int *start, unsigned int *len)
{ {
char *endptr = NULL, *token = NULL; char *endptr = NULL, *token = NULL;
@@ -568,7 +568,7 @@ int main(int argc, char *argv[])
int namelen, opt, i, j; int namelen, opt, i, j;
int startchip = -1, chipcount = 0, option_index = 0; int startchip = -1, chipcount = 0, option_index = 0;
int operation_specified = 0; int operation_specified = 0;
uint32_t wp_start = 0, wp_len = 0; unsigned int wp_start = 0, wp_len = 0;
bool force = false, ifd = false, fmap = false; bool force = false, ifd = false, fmap = false;
#if CONFIG_PRINT_WIKI == 1 #if CONFIG_PRINT_WIKI == 1
bool list_supported_wiki = false; bool list_supported_wiki = false;