openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-26 22:52:34 +02:00
Code Issues Releases Wiki Activity

CID1130011: Use after free in ich_descriptor_tool

Browse Source 
Corresponding to flashrom svn r1771.

Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
This commit is contained in:
Stefan Reinauer 2014-04-26 16:11:21 +00:00 committed by Stefan Tauner
parent f94d9ceaa6
commit a54169b3d1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
util/ich_descriptors_tool/ich_descriptors_tool.c
View File

@ -77,12 +77,13 @@ static void dump_file(const char *prefix, const uint32_t *dump, unsigned int len
printf("Dumping %u bytes of the %s region from 0x%08x-0x%08x to %s... ", printf("Dumping %u bytes of the %s region from 0x%08x-0x%08x to %s... ",
file_len, region_names[i], base, limit, fn); file_len, region_names[i], base, limit, fn);
int fh = open(fn, O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR); int fh = open(fn, O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR);
free(fn);
if (fh < 0) { if (fh < 0) {
fprintf(stderr, fprintf(stderr,
"ERROR: couldn't open(%s): %s\n", fn, strerror(errno)); "ERROR: couldn't open(%s): %s\n", fn, strerror(errno));
free(fn);
exit(1); exit(1);
} }
free(fn);
ret = write(fh, &dump[base >> 2], file_len); ret = write(fh, &dump[base >> 2], file_len);
if (ret != file_len) { if (ret != file_len) {