openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 15:12:36 +02:00
Code Issues Releases Wiki Activity

Refine text of requests to send logs

Browse Source 
A lot of messages sent@flashrom.org just have "flashrom -V" as the subject. 
Ask people to include more information in the subject line to make life
easier for developers/supporters.

Corresponding to flashrom svn r1202.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
This commit is contained in:
Paul Menzel 2010-10-08 11:03:02 +00:00 committed by Carl-Daniel Hailfinger
parent 174f55bdec
commit ab6328fa36
4 changed files with 22 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
board_enable.c
View File

@ -433,7 +433,9 @@ int it8705f_write_enable(uint8_t port)
max_rom_decode.parallel = 1024 * 1024; max_rom_decode.parallel = 1024 * 1024;
msg_pinfo("IT8705F with very unusual settings. Please " msg_pinfo("IT8705F with very unusual settings. Please "
"send the output of \"flashrom -V\" to \n" "send the output of \"flashrom -V\" to \n"
"flashrom@flashrom.org to help us finish " "flashrom@flashrom.org with "
"IT8705: your board name: flashrom -V\n"
"as the subject to help us finish "
"support for your Super I/O. Thanks.\n"); "support for your Super I/O. Thanks.\n");
ret = 1; ret = 1;
} else if (tmp & 0x08) { } else if (tmp & 0x08) {
@ -2097,7 +2099,8 @@ int board_flash_enable(const char *vendor, const char *part)
board = NULL; board = NULL;
} else { } else {
msg_pinfo("NOTE: Running an untested board enable procedure.\n" msg_pinfo("NOTE: Running an untested board enable procedure.\n"
"Please report success/failure to flashrom@flashrom.org.\n"); "Please report success/failure to flashrom@flashrom.org\n"
"with your board name and SUCCESS or FAILURE in the subject.\n");
} }
} }

11
chipset_enable.c
View File

@ -939,7 +939,9 @@ static int enable_flash_mcp6x_7x(struct pci_dev *dev, const char *name)
} }
out_msg: out_msg:
msg_pinfo("Please send the output of \"flashrom -V\" to " msg_pinfo("Please send the output of \"flashrom -V\" to "
"flashrom@flashrom.org to help us finish support for your " "flashrom@flashrom.org with\n"
"your board name: flashrom -V as the subject to help us "
"finish support for your\n"
"chipset. Thanks.\n"); "chipset. Thanks.\n");
return ret; return ret;
@ -1195,8 +1197,11 @@ int chipset_flash_enable(void)
continue; continue;
if (ret != -2) { if (ret != -2) {
msg_pinfo("WARNING: unexpected second chipset match: " msg_pinfo("WARNING: unexpected second chipset match: "
"\"%s %s\"\nignoring, please report lspci and " "\"%s %s\"\n"
"board URL to flashrom@flashrom.org!\n", "ignoring, please report lspci and board URL "
"to flashrom@flashrom.org\n"
"with 2CHIPSET: your board name in the "
"subject line.\n",
chipset_enables[i].vendor_name, chipset_enables[i].vendor_name,
chipset_enables[i].device_name); chipset_enables[i].device_name);
continue; continue;

7
flashrom.c
View File

@ -1314,7 +1314,8 @@ void emergency_help_message(void)
{ {
msg_gerr("Your flash chip is in an unknown state.\n" msg_gerr("Your flash chip is in an unknown state.\n"
"Get help on IRC at irc.freenode.net (channel #flashrom) or\n" "Get help on IRC at irc.freenode.net (channel #flashrom) or\n"
"mail flashrom@flashrom.org!\n" "mail flashrom@flashrom.org with FAILED: your board name in "
"the subject line!\n"
"-------------------------------------------------------------" "-------------------------------------------------------------"
"------------------\n" "------------------\n"
"DO NOT REBOOT OR POWEROFF!\n"); "DO NOT REBOOT OR POWEROFF!\n");
@ -1496,8 +1497,8 @@ void check_chip_supported(struct flashchip *flash)
"operations you tested (-V, -Vr,\n" "operations you tested (-V, -Vr,\n"
"-Vw, -VE), and mention which mainboard or " "-Vw, -VE), and mention which mainboard or "
"programmer you tested.\n" "programmer you tested.\n"
"Thanks for your help!\n" "Please mention your board in the subject line. "
"===\n"); "Thanks for your help!\n");
} }
} }

8
pcidev.c
View File

@ -66,9 +66,11 @@ uint32_t pcidev_validate(struct pci_dev *dev, uint32_t bar,
if (devs[i].status == NT) { if (devs[i].status == NT) {
msg_pinfo("===\nThis PCI device is UNTESTED. Please " msg_pinfo("===\nThis PCI device is UNTESTED. Please "
"report the 'flashrom -p xxxx' output \n" "report the 'flashrom -p xxxx' output \n"
"to flashrom@flashrom.org if it works " "to flashrom@flashrom.org if it works "
"for you. Thank you for your help!\n===\n"); "for you. Please add the name of your\n"
"PCI device to the subject. Thank you for "
"your help!\n===\n");
} }
return addr; return addr;