openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 22:43:17 +02:00
Code Issues Releases Wiki Activity

Move erase verification to generic code

Browse Source 
Erase functions are no longer called from chip drivers and thus their
internal erase verification can be moved to generic code. This also
makes it easier to skip the verify step if desired and to differentiate
between failed command submission and failed erase verification.

Corresponding to flashrom svn r1353.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
This commit is contained in:
Carl-Daniel Hailfinger
2011-06-26 17:04:16 +00:00
parent bfa021dd80
commit b4061f61cd
10 changed files with 21 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
jedec.c
View File

@ -264,10 +264,7 @@ static int erase_sector_jedec_common(struct flashchip *flash, unsigned int page,
/* wait for Toggle bit ready */
toggle_ready_jedec_slow(bios);
if (check_erased_range(flash, page, pagesize)) {
msg_cerr("ERASE FAILED!\n");
return -1;
}
/* FIXME: Check the status register for errors. */
return 0;
}
@ -297,16 +294,12 @@ static int erase_block_jedec_common(struct flashchip *flash, unsigned int block,
/* wait for Toggle bit ready */
toggle_ready_jedec_slow(bios);
if (check_erased_range(flash, block, blocksize)) {
msg_cerr("ERASE FAILED!\n");
return -1;
}
/* FIXME: Check the status register for errors. */
return 0;
}
static int erase_chip_jedec_common(struct flashchip *flash, unsigned int mask)
{
int total_size = flash->total_size * 1024;
chipaddr bios = flash->virtual_memory;
int delay_us = 0;
if(flash->probe_timing != TIMING_ZERO)
@ -329,10 +322,7 @@ static int erase_chip_jedec_common(struct flashchip *flash, unsigned int mask)
toggle_ready_jedec_slow(bios);
if (check_erased_range(flash, 0, total_size)) {
msg_cerr("ERASE FAILED!\n");
return -1;
}
/* FIXME: Check the status register for errors. */
return 0;
}