From b899ab233fc3e49386bfa5b4f88901aafe4d066e Mon Sep 17 00:00:00 2001 From: Anastasia Klimchuk Date: Tue, 26 Apr 2022 14:53:18 +1000 Subject: [PATCH] meson: Treat warnings as errors Makefile treats warnings as errors, so enable the same option for meson. Makefile has an option to disable "warnings as errors" option from command line. The same can be achieved with meson, see scenario 2 below. TEST=I verified the following scenarious 1) check that warnings treated as errors by enforcing higher warning level `meson setup --warnlevel=3 --wipe` `ninja test` shows tons of errors because warning level 3 is pedantic, build fails 2) disable "warning as errors" option from command line `meson configure -Dwerror=false` `ninja test` Now all warnings are non-blocking for build, so tests pass 3) back home `meson configure -Dwerror=true` `meson setup --warnlevel=2 --wipe` `ninja test` No warnings and tests pass 4) defaults: create new directory and run meson will all default options No warnings, all tests pass. Change-Id: I06c72abf1c861f9b35736e02ef7f4a4fb6909b97 Signed-off-by: Anastasia Klimchuk Reviewed-on: https://review.coreboot.org/c/flashrom/+/63852 Tested-by: build bot (Jenkins) Reviewed-by: Thomas Heijligen Reviewed-by: Peter Marheine --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 80ccfb38e..222f7c151 100644 --- a/meson.build +++ b/meson.build @@ -5,6 +5,7 @@ project('flashromutils', 'c', default_options : [ 'warning_level=2', 'c_std=c99', + 'werror=true', 'optimization=s', 'debug=false'], )