From b933dbc7642d3f94e56fc113f9a837473e2f5c3a Mon Sep 17 00:00:00 2001 From: Anastasia Klimchuk Date: Sat, 9 Nov 2024 23:15:16 +1100 Subject: [PATCH] flashchips: Skip "WP untested" message for SFDP-capable chip This entry in the flashchips represent a "SFDP-capable chip" and it doesn't make sense to show the message "WP operation has status untested, please report this". The entry can cover any generic SFDP chip and what would you report? Secondly, the entry "SFDP-capable chip" does not currently support WP operations anyway. Going further, we will be working with SFDP way more, so this area needs to be gradually upgraded. Testing: flashrom -p dummy:emulate=MX25L6436 -c "SFDP-capable chip" -r dump.rom Change-Id: I7e945389895a8042df3aaae72bccf73405be8651 Signed-off-by: Anastasia Klimchuk Reviewed-on: https://review.coreboot.org/c/flashrom/+/85075 Tested-by: build bot (Jenkins) Reviewed-by: Sergii Dmytruk Reviewed-by: Matti Finder --- flashchips.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flashchips.c b/flashchips.c index 73b403644..0e83200f9 100644 --- a/flashchips.c +++ b/flashchips.c @@ -23522,7 +23522,7 @@ const struct flashchip flashchips[] = { /* We present our own "report this" text hence we do not */ /* want the default "This flash part has status UNTESTED..." */ /* text to be printed. */ - .tested = TEST_OK_PREW, + .tested = { .probe = OK, .read = OK, .erase = OK, .write = OK, .wp = NA }, .probe = PROBE_SPI_SFDP, .block_erasers = {}, /* set by probing function */ .unlock = SPI_DISABLE_BLOCKPROTECT, /* is this safe? */