openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

Write MSRs in a platform and compiler-independent form

Browse Source 
Msr_t memory layout may depend on compiler; with optimizations this may
lead to writing incorrect data to MSR. Create a temporary buffer with
correct layout to avoid this problem.

Corresponding to flashrom svn r999.

Signed-off-by: Anti Sullin <anti.sullin@artecdesign.ee>
Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
This commit is contained in:
Anti Sullin 2010-05-17 23:19:22 +00:00 committed by Michael Karcher
parent 8841d3e703
commit be24d8198c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
physmap.c
View File

@ -282,13 +282,17 @@ msr_t rdmsr(int addr)
int wrmsr(int addr, msr_t msr) int wrmsr(int addr, msr_t msr)
{ {
uint32_t buf[2];
buf[0] = msr.lo;
buf[1] = msr.hi;
if (lseek(fd_msr, (off_t) addr, SEEK_SET) == -1) { if (lseek(fd_msr, (off_t) addr, SEEK_SET) == -1) {
perror("Could not lseek() to MSR"); perror("Could not lseek() to MSR");
close(fd_msr); close(fd_msr);
exit(1); exit(1);
} }
if (write(fd_msr, &msr, 8) != 8 && errno != EIO) { if (write(fd_msr, buf, 8) != 8 && errno != EIO) {
perror("Could not write() MSR"); perror("Could not write() MSR");
close(fd_msr); close(fd_msr);
exit(1); exit(1);