openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 15:12:36 +02:00
Code Issues Releases Wiki Activity

Revert "ft2232_spi: Fix broken GPIOL cs_bits state (#126)"

Browse Source 
This reverts commit a43e44b6abbe8381be3f3dd20a430973cf8b8ab5.

Nothing was broken. So this breaks everything. Well, actually only
the `csgpiol` parameter. But that is very obvious.

`csgpiol` was added to use a GPIO pin as /CS. But this change impli-
citly hardcoded /CS to ADBUS3.

Change-Id: I9ecdfe227585dda74658c16c96a57dd42d1d78b4
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55693
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
This commit is contained in:
Nico Huber 2021-06-20 14:37:55 +02:00
parent 6518cf352d
commit c3f765917d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ft2232_spi.c
View File

@ -226,7 +226,7 @@ static int ft2232_spi_send_multicommand(const struct flashctx *flash, struct spi
msg_pspew("Assert CS#\n"); msg_pspew("Assert CS#\n");
buf[i++] = SET_BITS_LOW; buf[i++] = SET_BITS_LOW;
buf[i++] = ~ 0x08 & spi_data->cs_bits; /* assert CS (3rd) bit only */ buf[i++] = 0 & ~spi_data->cs_bits; /* assertive */
buf[i++] = spi_data->pindir; buf[i++] = spi_data->pindir;
/* WREN, OP(PROGRAM, ERASE), ADDR, DATA */ /* WREN, OP(PROGRAM, ERASE), ADDR, DATA */