openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-28 15:33:42 +02:00
Code Issues Releases Wiki Activity

lspcon_i2c_spi: Release I2C fd on failed init

Browse Source 
Change-Id: Idec3cd349ab8d6e2ebb0fafae70c5d69bb2c8880
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/52829
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
This commit is contained in:
Angel Pons 2021-05-02 19:00:37 +02:00 committed by Edward O'Callaghan
parent 2bbc0704c1
commit c7dd17062c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lspcon_i2c_spi.c
View File

@ -502,12 +502,14 @@ int lspcon_i2c_spi_init(void)
int ret = lspcon_i2c_spi_reset_mpu_stop(fd); int ret = lspcon_i2c_spi_reset_mpu_stop(fd);
if (ret) { if (ret) {
msg_perr("%s: call to reset_mpu_stop failed.\n", __func__); msg_perr("%s: call to reset_mpu_stop failed.\n", __func__);
i2c_close(fd);
return ret; return ret;
} }
struct lspcon_i2c_spi_data *data = calloc(1, sizeof(struct lspcon_i2c_spi_data)); struct lspcon_i2c_spi_data *data = calloc(1, sizeof(struct lspcon_i2c_spi_data));
if (!data) { if (!data) {
msg_perr("Unable to allocate space for extra SPI master data.\n"); msg_perr("Unable to allocate space for extra SPI master data.\n");
i2c_close(fd);
return SPI_GENERIC_ERROR; return SPI_GENERIC_ERROR;
} }