openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-28 07:23:43 +02:00
Code Issues Releases Wiki Activity

layout: Fix overlap-check routine

Browse Source 
Fixes a regression introduced by commit 06a89d713 (layout: Introduce
layout_next()). A negation was dropped by accident which resulted in
comparisons with later, not-included regions instead of included ones.

Change-Id: I18168b9bd9a7d0fe2ba04fb091d1600f65d6dd5b
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55997
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Nico Huber 2021-07-01 15:17:17 +02:00 committed by Edward O'Callaghan
parent cd9b7b427d
commit c9039fc279
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
layout.c
View File

@ -257,7 +257,7 @@ int included_regions_overlap(const struct flashrom_layout *const l)
const struct romentry *rhs = lhs; const struct romentry *rhs = lhs;
while ((rhs = layout_next(l, rhs))) { while ((rhs = layout_next(l, rhs))) {
if (rhs->included) if (!rhs->included)
continue; continue;
if (lhs->start > rhs->end) if (lhs->start > rhs->end)