openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

sb600spi.c: Use one variable to store raw parameter values

Browse Source 
Currently, each programmer parameter has their own temp variable to
store their raw value into it. That's not needed since these variables
are only used for a short time to do some configuration and stay unused
then. Thus, use only one variable for all of them.

Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: I247012523c5e864ddb9e1e635df51e4311e5d5c5
Reviewed-on: https://review.coreboot.org/c/flashrom/+/65908
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
This commit is contained in:
Felix Singer 2022-07-16 11:09:16 +02:00 committed by Anastasia Klimchuk
parent 03bb6f77fb
commit ca4608db6f
1 changed files with 23 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
sb600spi.c
View File

@ -413,14 +413,13 @@ static int handle_speed(struct pci_dev *dev, enum amd_chipset amd_gen, uint8_t *
uint32_t tmp; uint32_t tmp;
int16_t spispeed_idx = -1; int16_t spispeed_idx = -1;
int16_t spireadmode_idx = -1; int16_t spireadmode_idx = -1;
char *spispeed; char *param_str;
char *spireadmode;
spispeed = extract_programmer_param_str("spispeed"); param_str = extract_programmer_param_str("spispeed");
if (spispeed != NULL) { if (param_str != NULL) {
unsigned int i; unsigned int i;
for (i = 0; i < ARRAY_SIZE(spispeeds); i++) { for (i = 0; i < ARRAY_SIZE(spispeeds); i++) {
if (strcasecmp(spispeeds[i], spispeed) == 0) { if (strcasecmp(spispeeds[i], param_str) == 0) {
spispeed_idx = i; spispeed_idx = i;
break; break;
} }
@ -429,36 +428,36 @@ static int handle_speed(struct pci_dev *dev, enum amd_chipset amd_gen, uint8_t *
* Error out on speeds not present in the spispeeds array. * Error out on speeds not present in the spispeeds array.
* Only Yangtze supports the second half of indices. * Only Yangtze supports the second half of indices.
* No 66 MHz before SB8xx. */ * No 66 MHz before SB8xx. */
if ((strcasecmp(spispeed, "reserved") == 0) || if ((strcasecmp(param_str, "reserved") == 0) ||
(i == ARRAY_SIZE(spispeeds)) || (i == ARRAY_SIZE(spispeeds)) ||
(amd_gen < CHIPSET_YANGTZE && spispeed_idx > 3) || (amd_gen < CHIPSET_YANGTZE && spispeed_idx > 3) ||
(amd_gen < CHIPSET_SB89XX && spispeed_idx == 0)) { (amd_gen < CHIPSET_SB89XX && spispeed_idx == 0)) {
msg_perr("Error: Invalid spispeed value: '%s'.\n", spispeed); msg_perr("Error: Invalid spispeed value: '%s'.\n", param_str);
free(spispeed); free(param_str);
return 1; return 1;
} }
free(spispeed); free(param_str);
} }
spireadmode = extract_programmer_param_str("spireadmode"); param_str = extract_programmer_param_str("spireadmode");
if (spireadmode != NULL) { if (param_str != NULL) {
unsigned int i; unsigned int i;
for (i = 0; i < ARRAY_SIZE(spireadmodes); i++) { for (i = 0; i < ARRAY_SIZE(spireadmodes); i++) {
if (strcasecmp(spireadmodes[i], spireadmode) == 0) { if (strcasecmp(spireadmodes[i], param_str) == 0) {
spireadmode_idx = i; spireadmode_idx = i;
break; break;
} }
} }
if ((strcasecmp(spireadmode, "reserved") == 0) || if ((strcasecmp(param_str, "reserved") == 0) ||
(i == ARRAY_SIZE(spireadmodes))) { (i == ARRAY_SIZE(spireadmodes))) {
msg_perr("Error: Invalid spireadmode value: '%s'.\n", spireadmode); msg_perr("Error: Invalid spireadmode value: '%s'.\n", param_str);
free(spireadmode); free(param_str);
return 1; return 1;
} }
if (amd_gen < CHIPSET_BOLTON) { if (amd_gen < CHIPSET_BOLTON) {
msg_perr("Warning: spireadmode not supported for this chipset."); msg_perr("Warning: spireadmode not supported for this chipset.");
} }
free(spireadmode); free(param_str);
} }
/* See the chipset support matrix for SPI Base_Addr below for an explanation of the symbols used. /* See the chipset support matrix for SPI Base_Addr below for an explanation of the symbols used.
@ -529,20 +528,20 @@ static int handle_imc(struct pci_dev *dev, enum amd_chipset amd_gen)
return 0; return 0;
bool amd_imc_force = false; bool amd_imc_force = false;
char *arg = extract_programmer_param_str("amd_imc_force"); char *param_value = extract_programmer_param_str("amd_imc_force");
if (arg && !strcmp(arg, "yes")) { if (param_value && !strcmp(param_value, "yes")) {
amd_imc_force = true; amd_imc_force = true;
msg_pspew("amd_imc_force enabled.\n"); msg_pspew("amd_imc_force enabled.\n");
} else if (arg && !strlen(arg)) { } else if (param_value && !strlen(param_value)) {
msg_perr("Missing argument for amd_imc_force.\n"); msg_perr("Missing argument for amd_imc_force.\n");
free(arg); free(param_value);
return 1; return 1;
} else if (arg) { } else if (param_value) {
msg_perr("Unknown argument for amd_imc_force: \"%s\" (not \"yes\").\n", arg); msg_perr("Unknown argument for amd_imc_force: \"%s\" (not \"yes\").\n", param_value);
free(arg); free(param_value);
return 1; return 1;
} }
free(arg); free(param_value);
/* TODO: we should not only look at IntegratedImcPresent (LPC Dev 20, Func 3, 40h) but also at /* TODO: we should not only look at IntegratedImcPresent (LPC Dev 20, Func 3, 40h) but also at
* IMCEnable(Strap) and Override EcEnable(Strap) (sb8xx, sb9xx?, a50, Bolton: Misc_Reg: 80h-87h; * IMCEnable(Strap) and Override EcEnable(Strap) (sb8xx, sb9xx?, a50, Bolton: Misc_Reg: 80h-87h;