openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-03 06:53:18 +02:00
Code Issues Releases Wiki Activity

tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE

Browse Source 
This patch adds NON_ZERO macro and not_null function into io_mock.h,
so that they can be used anywhere in tests. Common usage for not_null
is to indicate a valid pointer, where it doesn't matter what the
pointer is, only matters it is not null. Common usage of NON_ZERO is
to indicate a valid file descriptor, where it only matters the
descriptor is non-zero integer.

New features replace all usages of previous MOCK_HANDLE.

This patch corrects return value from __wrap_ioctl to be successful
by default. It used to be MOCK_HANDLE, but should be 0. Included in
this patch because this is also a replacement of MOCK_HANDLE.

BUG=b:181803212
TEST=builds and ninja test

Change-Id: I5ad6ee4aa9091447c6c9108c92bf7f6e755fca48
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/57269
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Anastasia Klimchuk
2021-10-14 12:21:02 +11:00
committed by Nico Huber
parent f42d2f72cc
commit d23613cf66
3 changed files with 23 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/include/test.h
View File

@ -27,4 +27,12 @@
#include <setjmp.h>
#include <cmocka.h>
#define NON_ZERO (0xf000baaa)
/*
* Having this as function allows to set a breakpoint on the address,
* as it has a named symbol associated with the address number.
*/
void *not_null(void);
#endif /* _TESTS_TEST_H */