From d431358621001a75497ebeae32277fcb5ecfc4da Mon Sep 17 00:00:00 2001 From: Anastasia Klimchuk Date: Mon, 25 Oct 2021 13:20:26 +1100 Subject: [PATCH] Add -W options from Makefile into meson warning_flags Makefile options were more restrictive and produced more warnings. This patch adds missing warning options into meson build. Makefile also has -Wall and -Wextra specified explicitly, however this is covered by warning_level=2 which is already set in meson.build. warning_level info: https://github.com/mesonbuild/meson/issues/3275 There are few warning options that are present in meson, but not in Makefile. These are left as is. TEST=ninja test shows no warnings and tests pass Change-Id: Id401bfd642dc3c13d85bd9a2dba56ada38714c25 Signed-off-by: Anastasia Klimchuk Reviewed-on: https://review.coreboot.org/c/flashrom/+/58561 Tested-by: build bot (Jenkins) Reviewed-by: Thomas Heijligen --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 32e31df35..e9eb4d25c 100644 --- a/meson.build +++ b/meson.build @@ -13,6 +13,8 @@ lt_version = '@0@.@1@.@2@'.format(lt_current, lt_age, lt_revision) # hide/enable some warnings warning_flags = [ + '-Wshadow', + '-Wmissing-prototypes', '-Wwrite-strings', '-Wno-unused-parameter', '-Wno-address-of-packed-member',