From d43c299ca8c4f3985eba6bc6e7266e67b37c25cb Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Mon, 12 Aug 2019 10:44:17 -0600 Subject: [PATCH] dummyflasher: Add error check for file read Print an error message and return if the read from emu_persistent_image fails. Change-Id: Icd1a72f9171e547f2081ba4bc53834a17ef7fcab Signed-off-by: Jacob Garber Found-by: Coverity CID 1403912 Reviewed-on: https://review.coreboot.org/c/flashrom/+/34845 Tested-by: build bot (Jenkins) Reviewed-by: David Hendricks Reviewed-on: https://review.coreboot.org/c/flashrom/+/67849 Reviewed-by: Felix Singer --- dummyflasher.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dummyflasher.c b/dummyflasher.c index 53801d9cb..3964226e5 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -378,8 +378,12 @@ int dummy_init(void) if (image_stat.st_size == emu_chip_size) { msg_pdbg("matches.\n"); msg_pdbg("Reading %s\n", emu_persistent_image); - read_buf_from_file(flashchip_contents, emu_chip_size, - emu_persistent_image); + if (read_buf_from_file(flashchip_contents, emu_chip_size, + emu_persistent_image)) { + msg_perr("Unable to read %s\n", emu_persistent_image); + free(flashchip_contents); + return 1; + } } else { msg_pdbg("doesn't match.\n"); }