openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-11-14 03:30:41 +01:00
Code Issues Releases Wiki Activity

libflashrom: Add flashrom_create_context to create and init context

Browse Source 
flashrom_create_context does create and all initialisations
needed for flash context.

The real life usage of flashrom_flash_probe_v2 discovered the issue:
error: variable 'flashctx' has initializer but incomplete type
error: storage size of 'flashctx' isn't known

flashrom_create_context fixes this, it would need to be called prior
to any other api calls that require flash context.

The patch also adds test which runs as external client for
libflashrom.
The test runs in a separate test executable, so that it does not
use flashrom source code but instead uses libflashrom as a
library.
It is also an example how to use libflashrom api.

Change-Id: I483f6cabb2b4ed27e0ee10bf621ae1bddb1fc9f3
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/89603
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
This commit is contained in:
Anastasia Klimchuk
2025-10-16 15:25:24 +11:00
parent 666f6366c9
commit d867ef7256
13 changed files with 266 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/lifecycle.c
View File

@@ -13,11 +13,12 @@ static void probe_chip_v2(const struct programmer_entry *prog,
const char **expected_matched_names,
unsigned int expected_matched_count)
{
struct flashrom_flashctx flashctx = { 0 };
struct flashrom_flashctx *flashctx = NULL;
assert_int_equal(0, flashrom_create_context(&flashctx));
const char **all_matched_names = NULL;
printf("Testing flashrom_flash_probe_v2 for programmer=%s, chip=%s ... \n", prog->name, chip_name);
assert_int_equal(expected_matched_count, flashrom_flash_probe_v2(&flashctx, &all_matched_names,
assert_int_equal(expected_matched_count, flashrom_flash_probe_v2(flashctx, &all_matched_names,
flashprog, chip_name));
for (unsigned int i = 0; i < expected_matched_count; i++)
@@ -26,14 +27,13 @@ static void probe_chip_v2(const struct programmer_entry *prog,
assert_null(all_matched_names[expected_matched_count]);
if (chip_name && expected_matched_count > 0)
assert_int_equal(0, strcmp(chip_name, flashctx.chip->name));
assert_int_equal(0, strcmp(chip_name, flashctx->chip->name));
printf("... flashrom_flash_probe_v2 for programmer=%s successful\n", prog->name);
/* cleanup */
flashrom_data_free(all_matched_names);
flashrom_layout_release(flashctx.default_layout);
free(flashctx.chip);
flashrom_flash_release(flashctx);
}
static void run_lifecycle(void **state, const struct io_mock *io, const struct programmer_entry *prog,