openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-28 07:23:43 +02:00
Code Issues Releases Wiki Activity

Add a few FIXME comments to the generic SPI code

Browse Source 
Corresponding to flashrom svn r814.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
This commit is contained in:
Carl-Daniel Hailfinger 2009-12-22 23:54:10 +00:00
parent 14e100c933
commit db53ec5373
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spi.c
View File

@ -807,6 +807,7 @@ int spi_write_status_register(int status)
int result; int result;
struct spi_command cmds[] = { struct spi_command cmds[] = {
{ {
/* FIXME: WRSR requires either EWSR or WREN depending on chip type. */
.writecnt = JEDEC_EWSR_OUTSIZE, .writecnt = JEDEC_EWSR_OUTSIZE,
.writearr = (const unsigned char[]){ JEDEC_EWSR }, .writearr = (const unsigned char[]){ JEDEC_EWSR },
.readcnt = 0, .readcnt = 0,
@ -1059,6 +1060,7 @@ int spi_aai_write(struct flashchip *flash, uint8_t *buf)
fprintf(stderr, "ERASE FAILED!\n"); fprintf(stderr, "ERASE FAILED!\n");
return -1; return -1;
} }
/* FIXME: This will fail on ICH/VIA SPI. */
result = spi_write_enable(); result = spi_write_enable();
if (result) if (result)
return result; return result;