From e0ed3b20df7201abfe5911338e162b7c314fa9af Mon Sep 17 00:00:00 2001 From: Miklos Marton Date: Thu, 15 Aug 2024 10:49:00 +0200 Subject: [PATCH] stlinkv3_spi: Mark STLinkV3-Mini not working The STLinkV3 Mini does not support the bridge API, it return LIBUSB_IO_ERROR when querying the bridge version. The official ST updater does not lists the bridge version in the info screen. Due to it's construction (additional connector on the bottom) it is likely that ST disabled the bridge functions on the castellated pads. Change-Id: Ic1ea4ca7acedca5d374cff8fcef450c18e55a9e8 Signed-off-by: Miklos Marton Reviewed-on: https://review.coreboot.org/c/flashrom/+/83921 Reviewed-by: Anastasia Klimchuk Tested-by: build bot (Jenkins) --- stlinkv3_spi.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c index f9046df01..29aa8d3cf 100644 --- a/stlinkv3_spi.c +++ b/stlinkv3_spi.c @@ -115,7 +115,7 @@ enum spi_nss_level { #define USB_TIMEOUT_IN_MS 5000 static const struct dev_entry devs_stlinkv3_spi[] = { - {0x0483, 0x374E, NT, "STMicroelectronics", "STLINK-V3E"}, + {0x0483, 0x374E, BAD, "STMicroelectronics", "STLINK-V3E"}, {0x0483, 0x374F, OK, "STMicroelectronics", "STLINK-V3S"}, {0x0483, 0x3753, OK, "STMicroelectronics", "STLINK-V3 dual VCP"}, {0x0483, 0x3754, NT, "STMicroelectronics", "STLINK-V3 no MSD"}, @@ -498,8 +498,14 @@ static int stlinkv3_spi_init(const struct programmer_cfg *cfg) devs_stlinkv3_spi[devIndex].vendor_id, devs_stlinkv3_spi[devIndex].device_id, param_str); - if (stlinkv3_handle) + if (stlinkv3_handle) { + if (devs_stlinkv3_spi[devIndex].status == BAD) { + msg_perr("The STLINK-V3 Mini/MiniE does not support the bridge interface\n"); + free(param_str); + goto init_err_exit; + } break; + } devIndex++; }