From e0ff1652a60e3fdcd82e3def8c9d13b071a4d05d Mon Sep 17 00:00:00 2001 From: Stefan Tauner Date: Sat, 22 Sep 2012 22:56:09 +0000 Subject: [PATCH] Fix a memleak in the dummyflasher Emu_persistent_image was not freed correctly. This bug was found thanks to valgrind. Corresponding to flashrom svn r1603. Signed-off-by: Stefan Tauner Acked-by: Carl-Daniel Hailfinger --- dummyflasher.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dummyflasher.c b/dummyflasher.c index 2803f76f3..655b67818 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -150,8 +150,9 @@ static int dummy_shutdown(void *data) if (emu_chip != EMULATE_NONE) { if (emu_persistent_image) { msg_pdbg("Writing %s\n", emu_persistent_image); - write_buf_to_file(flashchip_contents, emu_chip_size, - emu_persistent_image); + write_buf_to_file(flashchip_contents, emu_chip_size, emu_persistent_image); + free(emu_persistent_image); + emu_persistent_image = NULL; } free(flashchip_contents); }