openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

fmap.c: Remove unneeded 'else'

Browse Source 
'else' is not needed after a 'break' or 'return'.

Change-Id: I5df4d8075be012b9edf7be520d611042d9945094
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33345
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Elyes HAOUAS 2019-06-09 17:09:25 +02:00 committed by Nico Huber
parent a67ac58dd7
commit e276411e82
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fmap.c
View File

@ -132,9 +132,8 @@ int fmap_read_from_buffer(struct fmap **fmap_out, const uint8_t *const buf, size
if (offset < 0) { if (offset < 0) {
msg_gdbg("Unable to find fmap in provided buffer.\n"); msg_gdbg("Unable to find fmap in provided buffer.\n");
return 2; return 2;
} else {
msg_gdbg("Found fmap at offset 0x%06zx\n", (size_t)offset);
} }
msg_gdbg("Found fmap at offset 0x%06zx\n", (size_t)offset);
const struct fmap *fmap = (const struct fmap *)(buf + offset); const struct fmap *fmap = (const struct fmap *)(buf + offset);
*fmap_out = malloc(fmap_size(fmap)); *fmap_out = malloc(fmap_size(fmap));
@ -251,10 +250,9 @@ static int fmap_bsearch_rom(struct fmap **fmap_out, struct flashctx *const flash
msg_gdbg("fmap found at offset 0x%06zx\n", offset); msg_gdbg("fmap found at offset 0x%06zx\n", offset);
fmap_found = 1; fmap_found = 1;
break; break;
} else {
msg_gerr("fmap signature found at %zu but header is invalid.\n", offset);
ret = 2;
} }
msg_gerr("fmap signature found at %zu but header is invalid.\n", offset);
ret = 2;
} }
if (fmap_found) if (fmap_found)