openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 22:43:17 +02:00
Code Issues Releases Wiki Activity

tree: Change signature of extract_programmer_param_str()

Browse Source 
Results can be reproduced with the following invocation;
```
 $ find -name '*.c' -exec sed -i 's/extract_programmer_param_str(/extract_programmer_param_str(NULL, /g' '{}' \;
```

This allows for a pointer to the actual programmer parameters
to be passed instead of a global.

Change-Id: I781a328fa280e0a9601050dd99a75af72c39c899
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66654
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
This commit is contained in:
Edward O'Callaghan
2022-08-12 13:28:46 +10:00
committed by Anastasia Klimchuk
parent 33af2e695d
commit e316f1970d
32 changed files with 88 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal.c
View File

@ -128,7 +128,7 @@ static int get_params(int *boardenable, int *boardmismatch,
*board_vendor = NULL;
*board_model = NULL;
arg = extract_programmer_param_str("boardenable");
arg = extract_programmer_param_str(NULL, "boardenable");
if (arg && !strcmp(arg,"force")) {
*boardenable = 1;
} else if (arg && !strlen(arg)) {
@ -142,7 +142,7 @@ static int get_params(int *boardenable, int *boardmismatch,
}
free(arg);
arg = extract_programmer_param_str("boardmismatch");
arg = extract_programmer_param_str(NULL, "boardmismatch");
if (arg && !strcmp(arg,"force")) {
*boardmismatch = 1;
} else if (arg && !strlen(arg)) {
@ -156,7 +156,7 @@ static int get_params(int *boardenable, int *boardmismatch,
}
free(arg);
arg = extract_programmer_param_str("laptop");
arg = extract_programmer_param_str(NULL, "laptop");
if (arg && !strcmp(arg, "force_I_want_a_brick"))
*force_laptop = 1;
else if (arg && !strcmp(arg, "this_is_not_a_laptop"))
@ -172,7 +172,7 @@ static int get_params(int *boardenable, int *boardmismatch,
}
free(arg);
arg = extract_programmer_param_str("mainboard");
arg = extract_programmer_param_str(NULL, "mainboard");
if (arg && strlen(arg)) {
if (board_parse_parameter(arg, board_vendor, board_model)) {
free(arg);