From f949a3d1c62e76ccdd950f7a68605c5d56667ea0 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 20 Jun 2021 13:09:30 +0200 Subject: [PATCH] ft2232_spi: Don't lower write data chunksize This "chunk size" limits the amount of data that is passed to libusb at once. If we had exceeded the chunk size, libftdi would have split the data into individual, synchronous bulk transfers. But the chunk size was actually chosen to avoid this. So without any known effect, setting the chunk size is useless. Drop it. Change-Id: I779e24dc3f3379a98ddce02c3765062ac3241884 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/flashrom/+/55683 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Edward O'Callaghan --- ft2232_spi.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ft2232_spi.c b/ft2232_spi.c index 3fe7ea4dd..5b5d3cda0 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -651,10 +651,6 @@ static int ft2232_spi_init(void) msg_perr("Unable to set latency timer (%s).\n", ftdi_get_error_string(&ftdic)); } - if (ftdi_write_data_set_chunksize(&ftdic, 270)) { - msg_perr("Unable to set chunk size (%s).\n", ftdi_get_error_string(&ftdic)); - } - if (ftdi_set_bitmode(&ftdic, 0x00, BITMODE_BITBANG_SPI) < 0) { msg_perr("Unable to set bitmode to SPI (%s).\n", ftdi_get_error_string(&ftdic)); }