openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 06:01:16 +02:00
Code Issues Releases Wiki Activity

spi25_statusreg: Return defined value on failed RDSR

Browse Source 
The interface of spi_read_status_register() is broken and can't return
errors. Let's not return random stack data at least.

Change-Id: I714b20001a5443bba665c2e0061ca14069777581
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/22017
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
(cherry picked from commit 1f081530b6)
Reviewed-on: https://review.coreboot.org/22349
This commit is contained in:
Nico Huber
2017-10-14 15:01:13 +02:00
parent c2a11296e3
commit fcbdc0a007
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spi25_statusreg.c
View File

@ -117,8 +117,11 @@ uint8_t spi_read_status_register(struct flashctx *flash)
/* Read Status Register */ /* Read Status Register */
ret = spi_send_command(flash, sizeof(cmd), sizeof(readarr), cmd, readarr); ret = spi_send_command(flash, sizeof(cmd), sizeof(readarr), cmd, readarr);
if (ret) if (ret) {
msg_cerr("RDSR failed!\n"); msg_cerr("RDSR failed!\n");
/* FIXME: We should propagate the error. */
return 0;
}
return readarr[0]; return readarr[0];
} }