mirror of
https://review.coreboot.org/flashrom.git
synced 2025-04-26 14:42:36 +02:00
75dc0655b9
Original progress reporting implemented in CB:49643 and it has some
issues, for example:
size_t start_address = start;
size_t end_address = len - start;
End address is anything but length minus start address.
update_progress(flash,
FLASHROM_PROGRESS_READ,
/*current*/ start - start_address + to_read,
/*total*/ end_address);
Total should just be length if that's how current value is computed.
---
libflashrom needs to know total size ahead of time.
That's init_progress() and changed update_progress().
It also needs to store the last current value to be able to update it.
That's stage_progress in flashrom_flashctx.
Measuring accurately amount of data which will be read/erased/written
isn't easy because things can be skipped as optimizations. The next
patch in the chain aims to address this, there are TODO/FIXME
comments there.
---
CLI shares terminal with the rest of the code and has to maintain more
state to handle that reasonably well.
Similar to CB:64668, an effort is made to keep the progress on a
single line. Non-progress output is kept track of to know when
moving to a new line cannot be avoided.
---
A script to test the CLI:
\#!/bin/bash
t=${1:-rewW}
shift
if [[ $t =~ r ]]; then
echo ">>> READ"
./flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -r dump.rom --progress "$@"
echo
fi
if [[ $t =~ e ]]; then
echo ">>> ERASE"
./flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -E --progress "$@"
echo
fi
if [[ $t =~ w ]]; then
echo ">>> WRITE (without erase)"
dd if=/dev/zero of=zero.rom bs=1M count=16 2> /dev/null
./flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -w zero.rom --progress "$@"
echo
fi
if [[ $t =~ W ]]; then
echo ">>> WRITE (with erase)"
dd if=/dev/zero of=zero.rom bs=1M count=16 2> /dev/null
dd if=/dev/random of=random.rom bs=1M count=16 2> /dev/null
./flashrom -p dummy:emulate=W25Q128FV,freq=64mhz,image=random.rom -w zero.rom --progress "$@"
echo
fi
Co-developed-by: Anastasia Klimchuk <aklm@flashrom.org>
Co-developed-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Change-Id: If1e40fc97f443c4f0c0501cef11cff1f3f84c051
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/84102
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
85 lines
2.4 KiB
C
85 lines
2.4 KiB
C
/*
|
|
* This file is part of the flashrom project.
|
|
*
|
|
* Copyright (C) 2000 Silicon Integrated System Corporation
|
|
* Copyright (C) 2012 Rudolf Marek <r.marek@assembler.cz>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include "flash.h"
|
|
#include "chipdrivers.h"
|
|
|
|
/*
|
|
* WARNING!
|
|
* This chip uses the standard JEDEC addresses in 16-bit mode as word
|
|
* addresses. In byte mode, 0xAAA has to be used instead of 0x555 and
|
|
* 0x555 instead of 0x2AA. Do *not* blindly replace with standard JEDEC
|
|
* functions.
|
|
*/
|
|
|
|
/* chunksize is 2 */
|
|
int write_en29lv640b(struct flashctx *flash, const uint8_t *src, unsigned int start, unsigned int len)
|
|
{
|
|
unsigned int i;
|
|
chipaddr bios = flash->virtual_memory;
|
|
chipaddr dst = flash->virtual_memory + start;
|
|
|
|
for (i = 0; i < len; i += 2) {
|
|
chip_writeb(flash, 0xAA, bios + 0xAAA);
|
|
chip_writeb(flash, 0x55, bios + 0x555);
|
|
chip_writeb(flash, 0xA0, bios + 0xAAA);
|
|
|
|
/* Transfer data from source to destination. */
|
|
chip_writew(flash, (*src) | ((*(src + 1)) << 8 ), dst);
|
|
toggle_ready_jedec(flash, dst);
|
|
#if 0
|
|
/* We only want to print something in the error case. */
|
|
msg_cerr("Value in the flash at address 0x%lx = %#x, want %#x\n",
|
|
(dst - bios), chip_readb(flash, dst), *src);
|
|
#endif
|
|
dst += 2;
|
|
src += 2;
|
|
update_progress(flash, FLASHROM_PROGRESS_WRITE, 2);
|
|
}
|
|
|
|
/* FIXME: Ignore errors for now. */
|
|
return 0;
|
|
}
|
|
|
|
int probe_en29lv640b(struct flashctx *flash)
|
|
{
|
|
chipaddr bios = flash->virtual_memory;
|
|
uint16_t id1, id2;
|
|
|
|
chip_writeb(flash, 0xAA, bios + 0xAAA);
|
|
chip_writeb(flash, 0x55, bios + 0x555);
|
|
chip_writeb(flash, 0x90, bios + 0xAAA);
|
|
|
|
programmer_delay(flash, 10);
|
|
|
|
id1 = chip_readb(flash, bios + 0x200);
|
|
id1 |= (chip_readb(flash, bios) << 8);
|
|
|
|
id2 = chip_readb(flash, bios + 0x02);
|
|
|
|
chip_writeb(flash, 0xF0, bios + 0xAAA);
|
|
|
|
programmer_delay(flash, 10);
|
|
|
|
msg_cdbg("%s: id1 0x%04x, id2 0x%04x\n", __func__, id1, id2);
|
|
|
|
if (id1 == flash->chip->manufacture_id && id2 == flash->chip->model_id)
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|