mirror of
https://review.coreboot.org/flashrom.git
synced 2025-04-27 15:12:36 +02:00
02f43e89ba
Instead of using reversible write (rpci_write_long) that relies on global state, do it manually. Save original PCI config space register contents to programmer's structure during initialization and restore it in programmer's shutdown. TOPIC=reduce_global_pci_state TEST=builds Change-Id: I9996bb4d71801034e66ba0c233846e19fa29224d Signed-off-by: Alexander Goncharov <chat@joursoir.net> Ticket: https://ticket.coreboot.org/issues/389 Reviewed-on: https://review.coreboot.org/c/flashrom/+/65386 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Singer <felixsinger@posteo.net> Reviewed-by: Anastasia Klimchuk <aklm@chromium.org> Reviewed-by: Thomas Heijligen <src@posteo.de>
127 lines
3.2 KiB
C
127 lines
3.2 KiB
C
/*
|
|
* This file is part of the flashrom project.
|
|
*
|
|
* Copyright (C) 2010 Uwe Hermann <uwe@hermann-uwe.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include "flash.h"
|
|
#include "programmer.h"
|
|
#include "hwaccess_x86_io.h"
|
|
#include "platform/pci.h"
|
|
|
|
#define BIOS_ROM_ADDR 0x90
|
|
#define BIOS_ROM_DATA 0x94
|
|
|
|
#define REG_FLASH_ACCESS 0x58
|
|
#define BIT_FLASH_ACCESS BIT(24)
|
|
|
|
#define PCI_VENDOR_ID_HPT 0x1103
|
|
|
|
struct atahpt_data {
|
|
struct pci_dev *dev;
|
|
uint32_t io_base_addr;
|
|
uint32_t flash_access;
|
|
};
|
|
|
|
static const struct dev_entry ata_hpt[] = {
|
|
{0x1103, 0x0004, NT, "Highpoint", "HPT366/368/370/370A/372/372N"},
|
|
{0x1103, 0x0005, NT, "Highpoint", "HPT372A/372N"},
|
|
{0x1103, 0x0006, NT, "Highpoint", "HPT302/302N"},
|
|
|
|
{0},
|
|
};
|
|
|
|
static void atahpt_chip_writeb(const struct flashctx *flash, uint8_t val,
|
|
chipaddr addr)
|
|
{
|
|
struct atahpt_data *data = flash->mst->par.data;
|
|
|
|
OUTL((uint32_t)addr, data->io_base_addr + BIOS_ROM_ADDR);
|
|
OUTB(val, data->io_base_addr + BIOS_ROM_DATA);
|
|
}
|
|
|
|
static uint8_t atahpt_chip_readb(const struct flashctx *flash,
|
|
const chipaddr addr)
|
|
{
|
|
struct atahpt_data *data = flash->mst->par.data;
|
|
|
|
OUTL((uint32_t)addr, data->io_base_addr + BIOS_ROM_ADDR);
|
|
return INB(data->io_base_addr + BIOS_ROM_DATA);
|
|
}
|
|
|
|
static int atahpt_shutdown(void *par_data)
|
|
{
|
|
struct atahpt_data *data = par_data;
|
|
|
|
/* Restore original flash access state. */
|
|
pci_write_long(data->dev, REG_FLASH_ACCESS, data->flash_access);
|
|
|
|
free(par_data);
|
|
return 0;
|
|
}
|
|
|
|
static const struct par_master par_master_atahpt = {
|
|
.chip_readb = atahpt_chip_readb,
|
|
.chip_readw = fallback_chip_readw,
|
|
.chip_readl = fallback_chip_readl,
|
|
.chip_readn = fallback_chip_readn,
|
|
.chip_writeb = atahpt_chip_writeb,
|
|
.chip_writew = fallback_chip_writew,
|
|
.chip_writel = fallback_chip_writel,
|
|
.chip_writen = fallback_chip_writen,
|
|
.shutdown = atahpt_shutdown,
|
|
};
|
|
|
|
static int atahpt_init(void)
|
|
{
|
|
struct pci_dev *dev = NULL;
|
|
uint32_t io_base_addr;
|
|
|
|
if (rget_io_perms())
|
|
return 1;
|
|
|
|
dev = pcidev_init(ata_hpt, PCI_BASE_ADDRESS_4);
|
|
if (!dev)
|
|
return 1;
|
|
|
|
io_base_addr = pcidev_readbar(dev, PCI_BASE_ADDRESS_4);
|
|
if (!io_base_addr)
|
|
return 1;
|
|
|
|
struct atahpt_data *data = calloc(1, sizeof(*data));
|
|
if (!data) {
|
|
msg_perr("Unable to allocate space for PAR master data\n");
|
|
return 1;
|
|
}
|
|
data->dev = dev;
|
|
data->io_base_addr = io_base_addr;
|
|
|
|
/* Enable flash access. */
|
|
data->flash_access = pci_read_long(dev, REG_FLASH_ACCESS);
|
|
pci_write_long(dev, REG_FLASH_ACCESS, data->flash_access | BIT_FLASH_ACCESS);
|
|
|
|
return register_par_master(&par_master_atahpt, BUS_PARALLEL, data);
|
|
}
|
|
|
|
const struct programmer_entry programmer_atahpt = {
|
|
.name = "atahpt",
|
|
.type = PCI,
|
|
.devs.dev = ata_hpt,
|
|
.init = atahpt_init,
|
|
.map_flash_region = fallback_map,
|
|
.unmap_flash_region = fallback_unmap,
|
|
.delay = internal_delay,
|
|
};
|