mirror of
https://review.coreboot.org/flashrom.git
synced 2025-11-17 13:10:42 +01:00
359c535a05
Both the _POSIX_FSYNC macro and the fsync() declaration are in <unistd.h>. The current code works by accident on glibc courtesy of transitive includes, but is broken in Android currently (mistakenly assuming there is no fsync() because _POSIX_FSYNC isn't defined, merely because <unistd.h> hasn't been included), and won't compile with Android's C23 addition of call_once() to <stdlib.h> because _POSIX_FSYNC comes in transitively via <limits.h> but without <unistd.h> for the fsync() declaration. Fix all of this by just including the right POSIX header file for both the feature macro and the function declaration. Change-Id: Ifd6eeba56cffabb6a37880c78ea21de4705308b5 Signed-off-by: Elliott Hughes <enh@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/90015 Reviewed-by: Anastasia Klimchuk <aklm@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
125 lines
3.0 KiB
C
125 lines
3.0 KiB
C
/*
|
|
* This file is part of the flashrom project.
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later
|
|
* SPDX-FileCopyrightText: 2009-2010 Carl-Daniel Hailfinger
|
|
* SPDX-FileCopyrightText: 2013 Stefan Tauner
|
|
*/
|
|
|
|
#include <ctype.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
#include <unistd.h>
|
|
|
|
#ifndef __LIBPAYLOAD__
|
|
#include <fcntl.h>
|
|
#include <sys/stat.h>
|
|
#endif
|
|
|
|
#include "flash.h"
|
|
|
|
int read_buf_from_file(unsigned char *buf, unsigned long size,
|
|
const char *filename)
|
|
{
|
|
#ifdef __LIBPAYLOAD__
|
|
msg_gerr("Error: No file I/O support in libpayload\n");
|
|
return 1;
|
|
#else
|
|
int ret = 0;
|
|
|
|
FILE *image;
|
|
if (!strcmp(filename, "-"))
|
|
image = fdopen(fileno(stdin), "rb");
|
|
else
|
|
image = fopen(filename, "rb");
|
|
if (image == NULL) {
|
|
msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno));
|
|
return 1;
|
|
}
|
|
|
|
struct stat image_stat;
|
|
if (fstat(fileno(image), &image_stat) != 0) {
|
|
msg_gerr("Error: getting metadata of file \"%s\" failed: %s\n", filename, strerror(errno));
|
|
ret = 1;
|
|
goto out;
|
|
}
|
|
if ((image_stat.st_size != (intmax_t)size) && strcmp(filename, "-")) {
|
|
msg_gerr("Error: Image size (%jd B) doesn't match the expected size (%lu B)!\n",
|
|
(intmax_t)image_stat.st_size, size);
|
|
ret = 1;
|
|
goto out;
|
|
}
|
|
|
|
unsigned long numbytes = fread(buf, 1, size, image);
|
|
if (numbytes != size) {
|
|
msg_gerr("Error: Failed to read complete file. Got %ld bytes, "
|
|
"wanted %ld!\n", numbytes, size);
|
|
ret = 1;
|
|
}
|
|
out:
|
|
(void)fclose(image);
|
|
return ret;
|
|
#endif
|
|
}
|
|
|
|
/**
|
|
* @brief Writes passed data buffer into a file
|
|
*
|
|
* @param buf Buffer with data to write
|
|
* @param size Size of buffer
|
|
* @param filename File path to write to
|
|
* @return 0 on success
|
|
*/
|
|
int write_buf_to_file(const unsigned char *buf, unsigned long size, const char *filename)
|
|
{
|
|
#ifdef __LIBPAYLOAD__
|
|
msg_gerr("Error: No file I/O support in libpayload\n");
|
|
return 1;
|
|
#else
|
|
FILE *image;
|
|
int ret = 0;
|
|
|
|
if (!filename) {
|
|
msg_gerr("No filename specified.\n");
|
|
return 1;
|
|
}
|
|
if ((image = fopen(filename, "wb")) == NULL) {
|
|
msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno));
|
|
return 1;
|
|
}
|
|
|
|
unsigned long numbytes = fwrite(buf, 1, size, image);
|
|
if (numbytes != size) {
|
|
msg_gerr("Error: file %s could not be written completely.\n", filename);
|
|
ret = 1;
|
|
goto out;
|
|
}
|
|
if (fflush(image)) {
|
|
msg_gerr("Error: flushing file \"%s\" failed: %s\n", filename, strerror(errno));
|
|
ret = 1;
|
|
}
|
|
// Try to fsync() only regular files and if that function is available at all (e.g. not on MinGW).
|
|
#if defined(_POSIX_FSYNC) && (_POSIX_FSYNC != -1)
|
|
struct stat image_stat;
|
|
if (fstat(fileno(image), &image_stat) != 0) {
|
|
msg_gerr("Error: getting metadata of file \"%s\" failed: %s\n", filename, strerror(errno));
|
|
ret = 1;
|
|
goto out;
|
|
}
|
|
if (S_ISREG(image_stat.st_mode)) {
|
|
if (fsync(fileno(image))) {
|
|
msg_gerr("Error: fsyncing file \"%s\" failed: %s\n", filename, strerror(errno));
|
|
ret = 1;
|
|
}
|
|
}
|
|
#endif
|
|
out:
|
|
if (fclose(image)) {
|
|
msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno));
|
|
ret = 1;
|
|
}
|
|
return ret;
|
|
#endif
|
|
}
|