mirror of
https://review.coreboot.org/flashrom.git
synced 2025-04-27 07:02:34 +02:00
75b4536085
Given that the buffer size is known in advance, using malloc() is not necessary. To avoid open-coding buffer sizes, add some trailing null characters to `I2C_DEV_PREFIX`, as placeholders for bus number digits. Finally, replace the now-unnecessary `goto` statements with `return`. Change-Id: I6060749c6ded10949344caee3cc3943306e74a1c Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52415 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
103 lines
2.3 KiB
C
103 lines
2.3 KiB
C
/*
|
|
* This file is part of the flashrom project.
|
|
*
|
|
* Copyright (C) 2020 The Chromium OS Authors
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <errno.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <fcntl.h>
|
|
#include <sys/ioctl.h>
|
|
#include <unistd.h>
|
|
|
|
#include <stdlib.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/i2c-dev.h>
|
|
|
|
#include "flash.h"
|
|
#include "i2c_helper.h"
|
|
|
|
/* Null characters are placeholders for bus number digits */
|
|
#define I2C_DEV_PREFIX "/dev/i2c-\0\0\0"
|
|
#define I2C_MAX_BUS 255
|
|
|
|
int i2c_close(int fd)
|
|
{
|
|
return fd == -1 ? 0 : close(fd);
|
|
}
|
|
|
|
int i2c_open(int bus, uint16_t addr, int force)
|
|
{
|
|
char dev[sizeof(I2C_DEV_PREFIX)] = {0};
|
|
|
|
int ret = -1;
|
|
int fd = -1;
|
|
|
|
int request = force ? I2C_SLAVE_FORCE : I2C_SLAVE;
|
|
|
|
if (bus < 0 || bus > I2C_MAX_BUS) {
|
|
msg_perr("Invalid I2C bus %d.\n", bus);
|
|
return ret;
|
|
}
|
|
|
|
ret = snprintf(dev, sizeof(dev), "%s%d", I2C_DEV_PREFIX, bus);
|
|
if (ret < 0) {
|
|
msg_perr("Unable to join bus number to device name: %s.\n", strerror(errno));
|
|
return ret;
|
|
}
|
|
|
|
fd = open(dev, O_RDWR);
|
|
if (fd < 0) {
|
|
msg_perr("Unable to open I2C device %s: %s.\n", dev, strerror(errno));
|
|
return fd;
|
|
}
|
|
|
|
ret = ioctl(fd, request, addr);
|
|
if (ret < 0) {
|
|
msg_perr("Unable to set I2C slave address to 0x%02x: %s.\n", addr, strerror(errno));
|
|
i2c_close(fd);
|
|
return ret;
|
|
}
|
|
|
|
return fd;
|
|
}
|
|
|
|
int i2c_read(int fd, uint16_t addr, i2c_buffer_t *buf)
|
|
{
|
|
if (buf->len == 0)
|
|
return 0;
|
|
|
|
int ret = ioctl(fd, I2C_SLAVE, addr);
|
|
if (ret < 0) {
|
|
msg_perr("Unable to set I2C slave address to 0x%02x: %s.\n", addr, strerror(errno));
|
|
return ret;
|
|
}
|
|
|
|
return read(fd, buf->buf, buf->len);
|
|
}
|
|
|
|
int i2c_write(int fd, uint16_t addr, const i2c_buffer_t *buf)
|
|
{
|
|
if (buf->len == 0)
|
|
return 0;
|
|
|
|
int ret = ioctl(fd, I2C_SLAVE, addr);
|
|
if (ret < 0) {
|
|
msg_perr("Unable to set I2C slave address to 0x%02x: %s.\n", addr, strerror(errno));
|
|
return ret;
|
|
}
|
|
|
|
return write(fd, buf->buf, buf->len);
|
|
}
|