mirror of
https://review.coreboot.org/flashrom.git
synced 2025-04-27 07:02:34 +02:00
8bb2021d77
This patch attempts to resolve some programmer shutdown ordering issues by having the programmer init functions register shutdown callbacks explicitly wherever it makes most sense. Before, assumptions were made that could lead to the internal programmer's state changing before the external programmer could be shut down properly. Now, each programmer cleans up after itself and (hopefully) performs each operation in the correct order. As a side-effect, this patch gives us a better usage model for reverse operations such as rpci_* and rmmio_*. In the long-run, this should make reversing the initialization process easier to understand, less tedious, and less error-prone. In short, this patch does the following: - Registers a shutdown callback during initialization for each programmer. - Kills the .shutdown function pointer from programmer_entry struct. Also, make most shutdown functions static. - Adds a few minor clean-ups and corrections (e.g. missing physunmap() calls). TODO: Remove forward declaration of serprog_shutdown() (added to simplify diff) Corresponding to flashrom svn r1338. Signed-off-by: David Hendricks <dhendrix@google.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
80 lines
2.1 KiB
C
80 lines
2.1 KiB
C
/*
|
|
* This file is part of the flashrom project.
|
|
*
|
|
* Copyright (C) 2010 Uwe Hermann <uwe@hermann-uwe.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include "flash.h"
|
|
#include "programmer.h"
|
|
|
|
#define BIOS_ROM_ADDR 0x90
|
|
#define BIOS_ROM_DATA 0x94
|
|
|
|
#define REG_FLASH_ACCESS 0x58
|
|
|
|
#define PCI_VENDOR_ID_HPT 0x1103
|
|
|
|
const struct pcidev_status ata_hpt[] = {
|
|
{0x1103, 0x0004, NT, "Highpoint", "HPT366/368/370/370A/372/372N"},
|
|
{0x1103, 0x0005, NT, "Highpoint", "HPT372A/372N"},
|
|
{0x1103, 0x0006, NT, "Highpoint", "HPT302/302N"},
|
|
|
|
{},
|
|
};
|
|
|
|
static int atahpt_shutdown(void *data)
|
|
{
|
|
/* Flash access is disabled automatically by PCI restore. */
|
|
pci_cleanup(pacc);
|
|
release_io_perms();
|
|
return 0;
|
|
}
|
|
|
|
int atahpt_init(void)
|
|
{
|
|
uint32_t reg32;
|
|
|
|
get_io_perms();
|
|
|
|
io_base_addr = pcidev_init(PCI_BASE_ADDRESS_4, ata_hpt);
|
|
|
|
/* Enable flash access. */
|
|
reg32 = pci_read_long(pcidev_dev, REG_FLASH_ACCESS);
|
|
reg32 |= (1 << 24);
|
|
rpci_write_long(pcidev_dev, REG_FLASH_ACCESS, reg32);
|
|
|
|
buses_supported = CHIP_BUSTYPE_PARALLEL;
|
|
|
|
if (register_shutdown(atahpt_shutdown, NULL))
|
|
return 1;
|
|
return 0;
|
|
}
|
|
|
|
void atahpt_chip_writeb(uint8_t val, chipaddr addr)
|
|
{
|
|
OUTL((uint32_t)addr, io_base_addr + BIOS_ROM_ADDR);
|
|
OUTB(val, io_base_addr + BIOS_ROM_DATA);
|
|
}
|
|
|
|
uint8_t atahpt_chip_readb(const chipaddr addr)
|
|
{
|
|
OUTL((uint32_t)addr, io_base_addr + BIOS_ROM_ADDR);
|
|
return INB(io_base_addr + BIOS_ROM_DATA);
|
|
}
|