mirror of
https://review.coreboot.org/flashrom.git
synced 2025-04-27 15:12:36 +02:00
8bb2021d77
This patch attempts to resolve some programmer shutdown ordering issues by having the programmer init functions register shutdown callbacks explicitly wherever it makes most sense. Before, assumptions were made that could lead to the internal programmer's state changing before the external programmer could be shut down properly. Now, each programmer cleans up after itself and (hopefully) performs each operation in the correct order. As a side-effect, this patch gives us a better usage model for reverse operations such as rpci_* and rmmio_*. In the long-run, this should make reversing the initialization process easier to understand, less tedious, and less error-prone. In short, this patch does the following: - Registers a shutdown callback during initialization for each programmer. - Kills the .shutdown function pointer from programmer_entry struct. Also, make most shutdown functions static. - Adds a few minor clean-ups and corrections (e.g. missing physunmap() calls). TODO: Remove forward declaration of serprog_shutdown() (added to simplify diff) Corresponding to flashrom svn r1338. Signed-off-by: David Hendricks <dhendrix@google.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
97 lines
3.0 KiB
C
97 lines
3.0 KiB
C
/*
|
|
* This file is part of the flashrom project.
|
|
*
|
|
* Copyright (C) 2010 Andrew Morgan <ziltro@ziltro.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#if defined(__i386__) || defined(__x86_64__)
|
|
|
|
#include <stdlib.h>
|
|
#include "flash.h"
|
|
#include "programmer.h"
|
|
|
|
#define PCI_VENDOR_ID_NATSEMI 0x100b
|
|
|
|
#define BOOT_ROM_ADDR 0x50
|
|
#define BOOT_ROM_DATA 0x54
|
|
|
|
const struct pcidev_status nics_natsemi[] = {
|
|
{0x100b, 0x0020, NT, "National Semiconductor", "DP83815/DP83816"},
|
|
{0x100b, 0x0022, NT, "National Semiconductor", "DP83820"},
|
|
{},
|
|
};
|
|
|
|
static int nicnatsemi_shutdown(void *data)
|
|
{
|
|
pci_cleanup(pacc);
|
|
release_io_perms();
|
|
return 0;
|
|
}
|
|
|
|
int nicnatsemi_init(void)
|
|
{
|
|
get_io_perms();
|
|
|
|
io_base_addr = pcidev_init(PCI_BASE_ADDRESS_0, nics_natsemi);
|
|
|
|
buses_supported = CHIP_BUSTYPE_PARALLEL;
|
|
|
|
/* The datasheet shows address lines MA0-MA16 in one place and MA0-MA15
|
|
* in another. My NIC has MA16 connected to A16 on the boot ROM socket
|
|
* so I'm assuming it is accessible. If not then next line wants to be
|
|
* max_rom_decode.parallel = 65536; and the mask in the read/write
|
|
* functions below wants to be 0x0000FFFF.
|
|
*/
|
|
max_rom_decode.parallel = 131072;
|
|
|
|
if (register_shutdown(nicnatsemi_shutdown, NULL))
|
|
return 1;
|
|
return 0;
|
|
}
|
|
|
|
void nicnatsemi_chip_writeb(uint8_t val, chipaddr addr)
|
|
{
|
|
OUTL((uint32_t)addr & 0x0001FFFF, io_base_addr + BOOT_ROM_ADDR);
|
|
/*
|
|
* The datasheet requires 32 bit accesses to this register, but it seems
|
|
* that requirement might only apply if the register is memory mapped.
|
|
* Bits 8-31 of this register are apparently don't care, and if this
|
|
* register is I/O port mapped, 8 bit accesses to the lowest byte of the
|
|
* register seem to work fine. Due to that, we ignore the advice in the
|
|
* data sheet.
|
|
*/
|
|
OUTB(val, io_base_addr + BOOT_ROM_DATA);
|
|
}
|
|
|
|
uint8_t nicnatsemi_chip_readb(const chipaddr addr)
|
|
{
|
|
OUTL(((uint32_t)addr & 0x0001FFFF), io_base_addr + BOOT_ROM_ADDR);
|
|
/*
|
|
* The datasheet requires 32 bit accesses to this register, but it seems
|
|
* that requirement might only apply if the register is memory mapped.
|
|
* Bits 8-31 of this register are apparently don't care, and if this
|
|
* register is I/O port mapped, 8 bit accesses to the lowest byte of the
|
|
* register seem to work fine. Due to that, we ignore the advice in the
|
|
* data sheet.
|
|
*/
|
|
return INB(io_base_addr + BOOT_ROM_DATA);
|
|
}
|
|
|
|
#else
|
|
#error PCI port I/O access is not supported on this architecture yet.
|
|
#endif
|