mirror of
https://review.coreboot.org/flashrom.git
synced 2025-04-26 22:52:34 +02:00
b1794138f0
The initial implementation does not account for user_data, requiring
the calling application to use a global scope. This may lead to issues
related to object lifecycle management and other architectural
concerns.
This patch adds user_data to the user’s log callback. Moreover, it
performs message formatting, so the application only needs to pass
the formatted string to the selected output.
The change does not break the existing logging API but extends it.
A new API version is introduced with the v2 suffix.
Testing: Both unit tests and CLI tools serve as libflashrom clients.
All unit tests run successfully.
Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39
Signed-off-by: Dmitry Zhadinets <dzhadinets@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/86875
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
49 lines
1.3 KiB
Plaintext
49 lines
1.3 KiB
Plaintext
LIBFLASHROM_1.0 {
|
|
global:
|
|
flashrom_data_free;
|
|
flashrom_flag_get;
|
|
flashrom_flag_set;
|
|
flashrom_flash_erase;
|
|
flashrom_flash_getsize;
|
|
flashrom_flash_probe;
|
|
flashrom_flash_release;
|
|
flashrom_image_read;
|
|
flashrom_image_verify;
|
|
flashrom_image_write;
|
|
flashrom_init;
|
|
flashrom_layout_add_region;
|
|
flashrom_layout_exclude_region;
|
|
flashrom_layout_get_region_range;
|
|
flashrom_layout_include_region;
|
|
flashrom_layout_new;
|
|
flashrom_layout_read_fmap_from_buffer;
|
|
flashrom_layout_read_fmap_from_rom;
|
|
flashrom_layout_read_from_ifd;
|
|
flashrom_layout_release;
|
|
flashrom_layout_set;
|
|
flashrom_programmer_init;
|
|
flashrom_programmer_shutdown;
|
|
flashrom_set_log_callback;
|
|
flashrom_set_log_callback_v2;
|
|
flashrom_set_progress_callback;
|
|
flashrom_set_progress_callback_v2;
|
|
flashrom_shutdown;
|
|
flashrom_supported_boards;
|
|
flashrom_supported_chipsets;
|
|
flashrom_supported_flash_chips;
|
|
flashrom_version_info;
|
|
flashrom_wp_cfg_new;
|
|
flashrom_wp_cfg_release;
|
|
flashrom_wp_get_available_ranges;
|
|
flashrom_wp_get_mode;
|
|
flashrom_wp_get_range;
|
|
flashrom_wp_ranges_get_count;
|
|
flashrom_wp_ranges_get_range;
|
|
flashrom_wp_ranges_release;
|
|
flashrom_wp_read_cfg;
|
|
flashrom_wp_set_mode;
|
|
flashrom_wp_set_range;
|
|
flashrom_wp_write_cfg;
|
|
local: *;
|
|
};
|