1
0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 07:02:34 +02:00
flashrom/pickit2_spi.c
Felix Singer d4a46375da pickit2_spi.c: Use one variable to store raw parameter values
Currently, each programmer parameter has their own temp variable to
store their raw value into it. That's not needed since these variables
are only used for a short time to do some configuration and stay unused
then. Thus, use only one variable for all of them.

Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: Ib4ebc0e6354aad007145e1b0a761d9011c59ff7c
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66571
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
2022-08-14 23:49:58 +00:00

518 lines
13 KiB
C

/*
* This file is part of the flashrom project.
*
* Copyright (C) 2010 Carl-Daniel Hailfinger
* Copyright (C) 2014 Justin Chevrier
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
/*
* Connections are as follows:
*
* +------+-----+----------+
* | SPI | Pin | PICkit2 |
* +------+-----+----------+
* | /CS | 1 | VPP/MCLR |
* | VCC | 2 | VDD |
* | GND | 3 | GND |
* | MISO | 4 | PGD |
* | SCLK | 5 | PDC |
* | MOSI | 6 | AUX |
* +------+-----+----------+
*
* Inspiration and some specifics of the interface came via the AVRDude
* PICkit2 code: https://github.com/steve-m/avrdude/blob/master/pickit2.c
*/
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <limits.h>
#include <errno.h>
#include <libusb.h>
#include "flash.h"
#include "chipdrivers.h"
#include "programmer.h"
#include "spi.h"
static const struct dev_entry devs_pickit2_spi[] = {
{0x04D8, 0x0033, OK, "Microchip", "PICkit 2"},
{0}
};
struct pickit2_spi_data {
libusb_device_handle *pickit2_handle;
};
/* Default USB transaction timeout in ms */
#define DFLT_TIMEOUT 10000
#define CMD_LENGTH 64
#define ENDPOINT_OUT 0x01
#define ENDPOINT_IN 0x81
#define CMD_GET_VERSION 0x76
#define CMD_SET_VDD 0xA0
#define CMD_SET_VPP 0xA1
#define CMD_READ_VDD_VPP 0xA3
#define CMD_EXEC_SCRIPT 0xA6
#define CMD_CLR_DLOAD_BUFF 0xA7
#define CMD_DOWNLOAD_DATA 0xA8
#define CMD_CLR_ULOAD_BUFF 0xA9
#define CMD_UPLOAD_DATA 0xAA
#define CMD_END_OF_BUFFER 0xAD
#define SCR_SPI_READ_BUF 0xC5
#define SCR_SPI_WRITE_BUF 0xC6
#define SCR_SET_AUX 0xCF
#define SCR_LOOP 0xE9
#define SCR_SET_ICSP_CLK_PERIOD 0xEA
#define SCR_SET_PINS 0xF3
#define SCR_BUSY_LED_OFF 0xF4
#define SCR_BUSY_LED_ON 0xF5
#define SCR_MCLR_GND_OFF 0xF6
#define SCR_MCLR_GND_ON 0xF7
#define SCR_VPP_PWM_OFF 0xF8
#define SCR_VPP_PWM_ON 0xF9
#define SCR_VPP_OFF 0xFA
#define SCR_VPP_ON 0xFB
#define SCR_VDD_OFF 0xFE
#define SCR_VDD_ON 0xFF
static int pickit2_interrupt_transfer(libusb_device_handle *handle, unsigned char endpoint, unsigned char *data)
{
int transferred;
return libusb_interrupt_transfer(handle, endpoint, data, CMD_LENGTH, &transferred, DFLT_TIMEOUT);
}
static int pickit2_get_firmware_version(libusb_device_handle *pickit2_handle)
{
int ret;
uint8_t command[CMD_LENGTH] = {CMD_GET_VERSION, CMD_END_OF_BUFFER};
ret = pickit2_interrupt_transfer(pickit2_handle, ENDPOINT_OUT, command);
if (ret != 0) {
msg_perr("Command Get Firmware Version failed!\n");
return 1;
}
ret = pickit2_interrupt_transfer(pickit2_handle, ENDPOINT_IN, command);
if (ret != 0) {
msg_perr("Command Get Firmware Version failed!\n");
return 1;
}
msg_pdbg("PICkit2 Firmware Version: %d.%d\n", (int)command[0], (int)command[1]);
return 0;
}
static int pickit2_set_spi_voltage(libusb_device_handle *pickit2_handle, int millivolt)
{
double voltage_selector;
switch (millivolt) {
case 0:
/* Admittedly this one is an assumption. */
voltage_selector = 0;
break;
case 1800:
voltage_selector = 1.8;
break;
case 2500:
voltage_selector = 2.5;
break;
case 3500:
voltage_selector = 3.5;
break;
default:
msg_perr("Unknown voltage %i mV! Aborting.\n", millivolt);
return 1;
}
msg_pdbg("Setting SPI voltage to %u.%03u V\n", millivolt / 1000,
millivolt % 1000);
uint8_t command[CMD_LENGTH] = {
CMD_SET_VDD,
voltage_selector * 2048 + 672,
(voltage_selector * 2048 + 672) / 256,
voltage_selector * 36,
CMD_SET_VPP,
0x40,
voltage_selector * 18.61,
voltage_selector * 13,
CMD_END_OF_BUFFER
};
int ret = pickit2_interrupt_transfer(pickit2_handle, ENDPOINT_OUT, command);
if (ret != 0) {
msg_perr("Command Set Voltage failed!\n");
return 1;
}
return 0;
}
struct pickit2_spispeeds {
const char *const name;
const int speed;
};
static const struct pickit2_spispeeds spispeeds[] = {
{ "1M", 0x1 },
{ "500k", 0x2 },
{ "333k", 0x3 },
{ "250k", 0x4 },
{ NULL, 0x0 },
};
static int pickit2_set_spi_speed(libusb_device_handle *pickit2_handle, unsigned int spispeed_idx)
{
msg_pdbg("SPI speed is %sHz\n", spispeeds[spispeed_idx].name);
uint8_t command[CMD_LENGTH] = {
CMD_EXEC_SCRIPT,
2,
SCR_SET_ICSP_CLK_PERIOD,
spispeed_idx,
CMD_END_OF_BUFFER
};
int ret = pickit2_interrupt_transfer(pickit2_handle, ENDPOINT_OUT, command);
if (ret != 0) {
msg_perr("Command Set SPI Speed failed!\n");
return 1;
}
return 0;
}
static int pickit2_spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt,
const unsigned char *writearr, unsigned char *readarr)
{
struct pickit2_spi_data *pickit2_data = flash->mst->spi.data;
const unsigned int total_packetsize = writecnt + readcnt + 20;
/* Maximum number of bytes per transaction (including command overhead) is 64. Lets play it safe
* and always assume the worst case scenario of 20 bytes command overhead.
*/
if (total_packetsize > CMD_LENGTH) {
msg_perr("\nTotal packetsize (%i) is greater than %i supported, aborting.\n",
total_packetsize, CMD_LENGTH);
return 1;
}
uint8_t buf[CMD_LENGTH] = {CMD_DOWNLOAD_DATA, writecnt};
unsigned int i = 2;
for (; i < writecnt + 2; i++) {
buf[i] = writearr[i - 2];
}
buf[i++] = CMD_CLR_ULOAD_BUFF;
buf[i++] = CMD_EXEC_SCRIPT;
/* Determine script length based on number of bytes to be read or written */
if (writecnt == 1 && readcnt == 1)
buf[i++] = 7;
else if (writecnt == 1 || readcnt == 1)
buf[i++] = 10;
else
buf[i++] = 13;
/* Assert CS# */
buf[i++] = SCR_VPP_OFF;
buf[i++] = SCR_MCLR_GND_ON;
buf[i++] = SCR_SPI_WRITE_BUF;
if (writecnt > 1) {
buf[i++] = SCR_LOOP;
buf[i++] = 1; /* Loop back one instruction */
buf[i++] = writecnt - 1; /* Number of times to loop */
}
if (readcnt)
buf[i++] = SCR_SPI_READ_BUF;
if (readcnt > 1) {
buf[i++] = SCR_LOOP;
buf[i++] = 1; /* Loop back one instruction */
buf[i++] = readcnt - 1; /* Number of times to loop */
}
/* De-assert CS# */
buf[i++] = SCR_MCLR_GND_OFF;
buf[i++] = SCR_VPP_PWM_ON;
buf[i++] = SCR_VPP_ON;
buf[i++] = CMD_UPLOAD_DATA;
buf[i++] = CMD_END_OF_BUFFER;
int ret = pickit2_interrupt_transfer(pickit2_data->pickit2_handle, ENDPOINT_OUT, buf);
if (ret != 0) {
msg_perr("Send SPI failed!\n");
return 1;
}
if (readcnt) {
int length = 0;
ret = libusb_interrupt_transfer(pickit2_data->pickit2_handle,
ENDPOINT_IN, buf, CMD_LENGTH, &length, DFLT_TIMEOUT);
if (length == 0 || ret != 0) {
msg_perr("Receive SPI failed\n");
return 1;
}
/* First byte indicates number of bytes transferred from upload buffer */
if (buf[0] != readcnt) {
msg_perr("Unexpected number of bytes transferred, expected %i, got %i!\n",
readcnt, ret);
return 1;
}
/* Actual data starts at byte number two */
memcpy(readarr, &buf[1], readcnt);
}
return 0;
}
/* Copied from dediprog.c */
/* Might be useful for other USB devices as well. static for now. */
static int parse_voltage(char *voltage)
{
char *tmp = NULL;
int i;
int millivolt = 0, fraction = 0;
if (!voltage || !strlen(voltage)) {
msg_perr("Empty voltage= specified.\n");
return -1;
}
millivolt = (int)strtol(voltage, &tmp, 0);
voltage = tmp;
/* Handle "," and "." as decimal point. Everything after it is assumed
* to be in decimal notation.
*/
if ((*voltage == '.') || (*voltage == ',')) {
voltage++;
for (i = 0; i < 3; i++) {
fraction *= 10;
/* Don't advance if the current character is invalid,
* but continue multiplying.
*/
if ((*voltage < '0') || (*voltage > '9'))
continue;
fraction += *voltage - '0';
voltage++;
}
/* Throw away remaining digits. */
voltage += strspn(voltage, "0123456789");
}
/* The remaining string must be empty or "mV" or "V". */
tolower_string(voltage);
/* No unit or "V". */
if ((*voltage == '\0') || !strncmp(voltage, "v", 1)) {
millivolt *= 1000;
millivolt += fraction;
} else if (!strncmp(voltage, "mv", 2) ||
!strncmp(voltage, "millivolt", 9)) {
/* No adjustment. fraction is discarded. */
} else {
/* Garbage at the end of the string. */
msg_perr("Garbage voltage= specified.\n");
return -1;
}
return millivolt;
}
static int pickit2_shutdown(void *data)
{
struct pickit2_spi_data *pickit2_data = data;
/* Set all pins to float and turn voltages off */
uint8_t command[CMD_LENGTH] = {
CMD_EXEC_SCRIPT,
8,
SCR_SET_PINS,
3, /* Bit-0=1(PDC In), Bit-1=1(PGD In), Bit-2=0(PDC LL), Bit-3=0(PGD LL) */
SCR_SET_AUX,
1, /* Bit-0=1(Aux In), Bit-1=0(Aux LL) */
SCR_MCLR_GND_OFF,
SCR_VPP_OFF,
SCR_VDD_OFF,
SCR_BUSY_LED_OFF,
CMD_END_OF_BUFFER
};
int ret = pickit2_interrupt_transfer(pickit2_data->pickit2_handle, ENDPOINT_OUT, command);
if (ret != 0) {
msg_perr("Command Shutdown failed!\n");
ret = 1;
}
if (libusb_release_interface(pickit2_data->pickit2_handle, 0) != 0) {
msg_perr("Could not release USB interface!\n");
ret = 1;
}
libusb_close(pickit2_data->pickit2_handle);
libusb_exit(NULL);
free(data);
return ret;
}
static const struct spi_master spi_master_pickit2 = {
.max_data_read = 40,
.max_data_write = 40,
.command = pickit2_spi_send_command,
.multicommand = default_spi_send_multicommand,
.read = default_spi_read,
.write_256 = default_spi_write_256,
.write_aai = default_spi_write_aai,
.shutdown = pickit2_shutdown,
.probe_opcode = default_spi_probe_opcode,
};
static int pickit2_spi_init(void)
{
uint8_t buf[CMD_LENGTH] = {
CMD_EXEC_SCRIPT,
10, /* Script length */
SCR_SET_PINS,
2, /* Bit-0=0(PDC Out), Bit-1=1(PGD In), Bit-2=0(PDC LL), Bit-3=0(PGD LL) */
SCR_SET_AUX,
0, /* Bit-0=0(Aux Out), Bit-1=0(Aux LL) */
SCR_VDD_ON,
SCR_MCLR_GND_OFF, /* Let CS# float */
SCR_VPP_PWM_ON,
SCR_VPP_ON, /* Pull CS# high */
SCR_BUSY_LED_ON,
CMD_CLR_DLOAD_BUFF,
CMD_CLR_ULOAD_BUFF,
CMD_END_OF_BUFFER
};
libusb_device_handle *pickit2_handle;
struct pickit2_spi_data *pickit2_data;
int spispeed_idx = 0;
char *param_str;
param_str = extract_programmer_param_str("spispeed");
if (param_str != NULL) {
int i = 0;
for (; spispeeds[i].name; i++) {
if (strcasecmp(spispeeds[i].name, param_str) == 0) {
spispeed_idx = i;
break;
}
}
if (spispeeds[i].name == NULL) {
msg_perr("Error: Invalid 'spispeed' value.\n");
free(param_str);
return 1;
}
free(param_str);
}
int millivolt = 3500;
param_str = extract_programmer_param_str("voltage");
if (param_str != NULL) {
millivolt = parse_voltage(param_str);
free(param_str);
if (millivolt < 0)
return 1;
}
if (libusb_init(NULL) < 0) {
msg_perr("Couldn't initialize libusb!\n");
return -1;
}
#if LIBUSB_API_VERSION < 0x01000106
libusb_set_debug(NULL, 3);
#else
libusb_set_option(NULL, LIBUSB_OPTION_LOG_LEVEL, LIBUSB_LOG_LEVEL_INFO);
#endif
const uint16_t vid = devs_pickit2_spi[0].vendor_id;
const uint16_t pid = devs_pickit2_spi[0].device_id;
pickit2_handle = libusb_open_device_with_vid_pid(NULL, vid, pid);
if (pickit2_handle == NULL) {
msg_perr("Could not open device PICkit2!\n");
libusb_exit(NULL);
return 1;
}
if (libusb_set_configuration(pickit2_handle, 1) != 0) {
msg_perr("Could not set USB device configuration.\n");
libusb_close(pickit2_handle);
libusb_exit(NULL);
return 1;
}
if (libusb_claim_interface(pickit2_handle, 0) != 0) {
msg_perr("Could not claim USB device interface\n");
libusb_close(pickit2_handle);
libusb_exit(NULL);
return 1;
}
pickit2_data = calloc(1, sizeof(*pickit2_data));
if (!pickit2_data) {
msg_perr("Unable to allocate space for SPI master data\n");
libusb_close(pickit2_handle);
libusb_exit(NULL);
return 1;
}
pickit2_data->pickit2_handle = pickit2_handle;
if (pickit2_get_firmware_version(pickit2_handle))
goto init_err_cleanup_exit;
/* Command Set SPI Speed */
if (pickit2_set_spi_speed(pickit2_handle, spispeed_idx))
goto init_err_cleanup_exit;
/* Command Set SPI Voltage */
msg_pdbg("Setting voltage to %i mV.\n", millivolt);
if (pickit2_set_spi_voltage(pickit2_handle, millivolt) != 0)
goto init_err_cleanup_exit;
/* Perform basic setup.
* Configure pin directions and logic levels, turn Vdd on, turn busy LED on and clear buffers. */
if (pickit2_interrupt_transfer(pickit2_handle, ENDPOINT_OUT, buf) != 0) {
msg_perr("Command Setup failed!\n");
goto init_err_cleanup_exit;
}
return register_spi_master(&spi_master_pickit2, pickit2_data);
init_err_cleanup_exit:
pickit2_shutdown(pickit2_data);
return 1;
}
const struct programmer_entry programmer_pickit2_spi = {
.name = "pickit2_spi",
.type = USB,
.devs.dev = devs_pickit2_spi,
.init = pickit2_spi_init,
.map_flash_region = fallback_map,
.unmap_flash_region = fallback_unmap,
.delay = internal_delay,
};