mirror of
https://review.coreboot.org/flashrom.git
synced 2025-04-27 23:22:37 +02:00

This change addresses the following ASAN error detected in the chromium tree: * ASAN error detected: * ================================================================= * ==12==ERROR: AddressSanitizer: global-buffer-overflow on address 0x55a8a046c916 at pc 0x55a8a038a21d bp 0x7ffd5dbc9ed0 sp 0x7ffd5dbc9ec8 * READ of size 2 at 0x55a8a046c916 thread T0 * #0 0x55a8a038a21c in nicrealtek_init /build/amd64-generic/tmp/por tage/sys-apps/flashrom-9999/work/flashrom-9999-build/../flashrom-9999/ni crealtek.c:119:15 * #1 0x55a8a032f172 in __sanitizer::BufferedStackTrace::UnwindImpl( unsigned long, unsigned long, void*, bool, unsigned int) ??:0:0 * #2 0x55a8a02b65b8 in __asan::ErrorGeneric::Print() ??:0:0 * #3 0x55a8a03294d5 in __asan::ScopedInErrorReport::~ScopedInErrorR eport() ??:0:0 * #4 0x55a8a032c5ae in __asan::ReportGenericError(unsigned long, un signed long, unsigned long, unsigned long, bool, unsigned long, unsigned int, bool) ??:0:0 * #5 0x55a8a032d0f7 in __asan_report_load2 ??:0:0 * * 0x55a8a046c916 is located 18 bytes to the right of global variable 'm ock_pci_dev' defined in '../flashrom-9999/tests/tests.c:50:16' (0x55a8a0 46c900) of size 4 * SUMMARY: AddressSanitizer: global-buffer-overflow (/tmp/portage/sys-a pps/flashrom-9999/work/flashrom-9999-build/tests/flashrom_unit_tests+0x1 9a21c) * Shadow bytes around the buggy address: * 0x0ab5940858d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0x0ab5940858e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0x0ab5940858f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0x0ab594085900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0x0ab594085910: 00 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9 f9 00 00 * =>0x0ab594085920: 04 f9[f9]f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085930: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085940: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085950: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085960: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085970: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * Shadow byte legend (one shadow byte represents 8 application bytes): * Addressable: 00 * Partially addressable: 01 02 03 04 05 06 07 * Heap left redzone: fa * Freed heap region: fd * Stack left redzone: f1 * Stack mid redzone: f2 * Stack right redzone: f3 * Stack after return: f5 * Stack use after scope: f8 * Global redzone: f9 * Global init order: f6 * Poisoned by user: f7 * Container overflow: fc * Array cookie: ac * Intra object redzone: bb * ASan internal: fe * Left alloca redzone: ca * Right alloca redzone: cb * ==12==ABORTING BUG=b:224828279 TEST=./test_build.sh; FEATURES=test emerge-amd64-generic flashrom BRANCH=none Signed-off-by: Daniel Campello <campello@chromium.org> Change-Id: I47943bf70181a9041f287df3ece0f7067a112de8 Reviewed-on: https://review.coreboot.org/c/flashrom/+/62845 Reviewed-by: Anastasia Klimchuk <aklm@chromium.org> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
115 lines
4.2 KiB
C
115 lines
4.2 KiB
C
/*
|
|
* This file is part of the flashrom project.
|
|
*
|
|
* Copyright (c) 2021 Nico Huber <nico.h@gmx.de>
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. Neither the name of the author nor the names of its contributors
|
|
* may be used to endorse or promote products derived from this
|
|
* software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef _IO_MOCK_H_
|
|
#define _IO_MOCK_H_
|
|
|
|
/* Required for `FILE *` */
|
|
#include <stdio.h>
|
|
|
|
/*
|
|
* Explicitly including the header because some tests are using libusb structs
|
|
* in depth, opaque symbols are not sufficient.
|
|
*/
|
|
#include <libusb.h>
|
|
|
|
/* Address value needs fit into uint8_t. */
|
|
#define USB_DEVICE_ADDRESS 19
|
|
|
|
/* Define struct pci_dev to avoid dependency on pci.h */
|
|
struct pci_dev {
|
|
char padding[18];
|
|
unsigned int device_id;
|
|
};
|
|
|
|
/* POSIX open() flags, avoiding dependency on fcntl.h */
|
|
#define O_RDONLY 0
|
|
#define O_WRONLY 1
|
|
#define O_RDWR 2
|
|
|
|
/* Linux I2C interface constants, avoiding linux/i2c-dev.h */
|
|
#define I2C_SLAVE 0x0703
|
|
|
|
/* Always return success for tests. */
|
|
#define S_ISREG(x) 0
|
|
|
|
struct io_mock {
|
|
void *state;
|
|
|
|
/* Port I/O */
|
|
void (*outb)(void *state, unsigned char value, unsigned short port);
|
|
unsigned char (*inb)(void *state, unsigned short port);
|
|
|
|
void (*outw)(void *state, unsigned short value, unsigned short port);
|
|
unsigned short (*inw)(void *state, unsigned short port);
|
|
|
|
void (*outl)(void *state, unsigned int value, unsigned short port);
|
|
unsigned int (*inl)(void *state, unsigned short port);
|
|
|
|
/* USB I/O */
|
|
int (*libusb_init)(void *state, libusb_context **ctx);
|
|
int (*libusb_control_transfer)(void *state,
|
|
libusb_device_handle *devh,
|
|
uint8_t bmRequestType,
|
|
uint8_t bRequest,
|
|
uint16_t wValue,
|
|
uint16_t wIndex,
|
|
unsigned char *data,
|
|
uint16_t wLength,
|
|
unsigned int timeout);
|
|
ssize_t (*libusb_get_device_list)(void *state, libusb_context *, libusb_device ***list);
|
|
void (*libusb_free_device_list)(void *state, libusb_device **list, int unref_devices);
|
|
int (*libusb_get_device_descriptor)(void *state, libusb_device *, struct libusb_device_descriptor *);
|
|
int (*libusb_get_config_descriptor)(void *state,
|
|
libusb_device *,
|
|
uint8_t config_index,
|
|
struct libusb_config_descriptor **);
|
|
void (*libusb_free_config_descriptor)(void *state, struct libusb_config_descriptor *);
|
|
|
|
/* POSIX File I/O */
|
|
int (*open)(void *state, const char *pathname, int flags);
|
|
int (*ioctl)(void *state, int fd, unsigned long request, va_list args);
|
|
int (*read)(void *state, int fd, void *buf, size_t sz);
|
|
int (*write)(void *state, int fd, const void *buf, size_t sz);
|
|
|
|
/* Standard I/O */
|
|
FILE* (*fopen)(void *state, const char *pathname, const char *mode);
|
|
char* (*fgets)(void *state, char *buf, int len, FILE *fp);
|
|
size_t (*fread)(void *state, void *buf, size_t size, size_t len, FILE *fp);
|
|
int (*fprintf)(void *state, FILE *fp, const char *fmt, va_list args);
|
|
int (*fclose)(void *state, FILE *fp);
|
|
};
|
|
|
|
void io_mock_register(const struct io_mock *io);
|
|
|
|
const struct io_mock *get_io(void);
|
|
|
|
#endif
|