mirror of
https://review.coreboot.org/flashrom.git
synced 2025-08-28 17:20:42 +02:00
eab86bcf8b
Patch Set 1:
(3 comments)
Patch-set: 1
Attention: {"person_ident":"Gerrit User 1005280 \u003c1005280@b08889c0-1fd2-4901-800c-8cbc5bd2cb46\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1003192\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1003192 \u003c1003192@b08889c0-1fd2-4901-800c-8cbc5bd2cb46\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1003192\u003e replied on the change"}
73 lines
2.0 KiB
Plaintext
73 lines
2.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "578e93b9_f67537ab",
|
|
"filename": "flashchips.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 11104,
|
|
"author": {
|
|
"id": 1003192
|
|
},
|
|
"writtenOn": "2024-06-07T05:31:15Z",
|
|
"side": 1,
|
|
"message": "Datasheet says `8K-bit secured OTP` so I think this is 1024B",
|
|
"range": {
|
|
"startLine": 11104,
|
|
"startChar": 10,
|
|
"endLine": 11104,
|
|
"endChar": 14
|
|
},
|
|
"revId": "d86e1066b03e90a373bc7f2f10cefaa93af07a32",
|
|
"serverId": "b08889c0-1fd2-4901-800c-8cbc5bd2cb46"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "534bf2b2_4d87f9b0",
|
|
"filename": "flashchips.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 11114,
|
|
"author": {
|
|
"id": 1003192
|
|
},
|
|
"writtenOn": "2024-06-07T05:31:15Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t see it in datasheet (I mean: 21h, 5Ch, DCh)? I see there is:\n\n20h for 4K\n52h for 32K\nD8h for 64K\n60h or C7h for chip erase\n\nI am looking at sections 10-24 and to 10-27 which describe erase commands?",
|
|
"range": {
|
|
"startLine": 11111,
|
|
"startChar": 3,
|
|
"endLine": 11114,
|
|
"endChar": 5
|
|
},
|
|
"revId": "d86e1066b03e90a373bc7f2f10cefaa93af07a32",
|
|
"serverId": "b08889c0-1fd2-4901-800c-8cbc5bd2cb46"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "05089391_e1ed2a9e",
|
|
"filename": "flashchips.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 11137,
|
|
"author": {
|
|
"id": 1003192
|
|
},
|
|
"writtenOn": "2024-06-07T05:31:15Z",
|
|
"side": 1,
|
|
"message": "You can remove TODO, you added security register bits below",
|
|
"range": {
|
|
"startLine": 11137,
|
|
"startChar": 2,
|
|
"endLine": 11137,
|
|
"endChar": 31
|
|
},
|
|
"revId": "d86e1066b03e90a373bc7f2f10cefaa93af07a32",
|
|
"serverId": "b08889c0-1fd2-4901-800c-8cbc5bd2cb46"
|
|
}
|
|
]
|
|
} |