mirror of
https://review.coreboot.org/flashrom.git
synced 2025-07-20 06:50:21 +02:00
af51624516
Building authors/reviewers list (aka Hall of Fame) requires
more modern sphinx version than the rest of documentation. Also
we have separate meson options, `documentation` and
`generate_authors_list`, which both default to `auto`.
Auto mode is expected to check the environment and enable the
option if environment is suitable - or disable otherwise.
The patch check minimun required sphinx version specifically
for building hall of fame, the rest of documentation just checks
that sphinx is present.
So if developer has old version of sphinx, all the documentation
will be built, just without hall of fame.
Without this patch, developer with generate_authors_list=auto
(which is default) and old version of sphinx gets a build error
like this:
Exception occurred:
File "/usr/lib/python3/dist-packages/docutils/nodes.py",
line 652, in __getitem__
return self.attributes[key]
KeyError: 'colwidth'
and a stack trace from sphinx source code
Change-Id: I8f0ae62f33dca04c2c5233ea45c6263f10cbe4f9
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/88373
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>