dh/ima-evm-utils-mirror
1
0
Fork 0
mirror of https://git.code.sf.net/p/linux-ima/ima-evm-utils synced 2025-04-27 22:32:31 +02:00
Code Releases Activity

Log and reset 'errno' on lsetxattr failure

Browse Source 
Writing either security.ima hashes or security.evm hmacs from userspace
will fail regardless of the IMA or EVM fix mode.  In fix mode, 'touch'
will force security.ima and security.evm to be updated.

Make the setxattr error messages more explicit and clear errno.

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
This commit is contained in:
Mimi Zohar 2022-10-28 16:13:52 -04:00
parent ba2b6a97c1
commit 1fcac50e30
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/evmctl.c
View File

@ -572,7 +572,8 @@ static int sign_evm(const char *file, const char *key)
if (xattr) {
err = lsetxattr(file, xattr_evm, sig, len, 0);
if (err < 0) {
log_err("setxattr failed: %s\n", file);
log_errno_reset(LOG_ERR, "Setting EVM xattr failed: %s",
file);
return err;
}
}
@ -615,7 +616,9 @@ static int hash_ima(const char *file)
if (xattr) {
err = lsetxattr(file, xattr_ima, hash, len, 0);
if (err < 0) {
log_err("setxattr failed: %s\n", file);
log_errno_reset(LOG_ERR,
"Setting IMA hash xattr failed: %s",
file);
return err;
}
}
@ -652,7 +655,9 @@ static int sign_ima(const char *file, const char *key)
if (xattr) {
err = lsetxattr(file, xattr_ima, sig, len, 0);
if (err < 0) {
log_err("setxattr failed: %s\n", file);
log_errno_reset(LOG_ERR,
"Setting IMA sig xattr failed: %s",
file);
return err;
}
}
@ -1125,7 +1130,8 @@ static int setxattr_ima(const char *file, char *sig_file)
err = lsetxattr(file, xattr_ima, sig, len, 0);
if (err < 0)
log_err("setxattr failed: %s\n", file);
log_errno_reset(LOG_ERR, "Setting IMA sig xattr failed: %s",
file);
free(sig);
return err;
}
@ -1323,7 +1329,9 @@ static int hmac_evm(const char *file, const char *key)
sig[0] = EVM_XATTR_HMAC;
err = lsetxattr(file, xattr_evm, sig, len + 1, 0);
if (err < 0) {
log_err("setxattr failed: %s\n", file);
log_errno_reset(LOG_ERR,
"Setting EVM hmac xattr failed: %s",
file);
return err;
}
}