openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 07:02:34 +02:00
Code Issues Releases Wiki Activity

rayer_spi.c: Drop lpt_outbyte intermediate var

Browse Source 
The intermediate variable in this case serves no extra
assistance in readability or additional control flow
branching. Just assign the result directly into the
driver state tracker.

Change-Id: Idedabb7b1c401d666b3b7e621e75704c7e765fd1
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68232
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Edward O'Callaghan 2022-10-08 12:14:42 +11:00 committed by Edward O'Callaghan
parent 68e4d5cc4e
commit 1837f0df27
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rayer_spi.c
View File

@ -283,7 +283,6 @@ static int rayer_spi_init(const struct programmer_cfg *cfg)
const struct rayer_programmer *prog = rayer_spi_types;
struct rayer_pinout *pinout = NULL;
uint16_t lpt_iobase;
uint8_t lpt_outbyte;
char *prog_type;
if (get_params(cfg, &lpt_iobase, &prog_type) < 0)
@ -312,9 +311,6 @@ static int rayer_spi_init(const struct programmer_cfg *cfg)
if (rget_io_perms())
return 1;
/* Get the initial value before writing to any line. */
lpt_outbyte = INB(lpt_iobase);
struct rayer_spi_data *data = calloc(1, sizeof(*data));
if (!data) {
msg_perr("Unable to allocate space for SPI master data\n");
@ -322,7 +318,8 @@ static int rayer_spi_init(const struct programmer_cfg *cfg)
}
data->pinout = pinout;
data->lpt_iobase = lpt_iobase;
data->lpt_outbyte = lpt_outbyte;
/* Get the initial value before writing to any line. */
data->lpt_outbyte = INB(lpt_iobase);
if (pinout->shutdown)
register_shutdown(pinout->shutdown, data);