openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-28 07:23:43 +02:00
Code Issues Releases Wiki Activity

Force enabling SPI mode for SB600 is a bad idea and leads to hangs

Browse Source 
Only access LPC ROM if we boot via LPC ROM. Only access SPI ROM if we
boot via SPI ROM.
The code to force enable SPI is commented out in case someone wants to
reenable it for a particular board with LPC and SPI flash.

Corresponding to flashrom svn r459.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
This commit is contained in:
Zheng Bao 2009-05-04 22:33:50 +00:00 committed by Carl-Daniel Hailfinger
parent 98aa032c16
commit 284a60065d
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
chipset_enable.c
View File

@ -680,8 +680,16 @@ static int enable_flash_sb600(struct pci_dev *dev, const char *name)
flashbus = BUS_TYPE_SB600_SPI;
/* Enable SPI ROM in SB600 PM register. */
/* If we enable SPI ROM here, we have to disable it after we leave.
* But how can we know which ROM we are going to handle? So we have
* to trade off. We only access LPC ROM if we boot via LPC ROM. And
* only SPI ROM if we boot via SPI ROM. If you want to do it crossly,
* you have to use the code below.
*/
/*
OUTB(0x8f, 0xcd6);
OUTB(0x0e, 0xcd7);
*/
return 0;
}