openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-30 08:23:42 +02:00
Code Issues Releases Wiki Activity

All "unknown xy SPI chip" entries claim to have status UNTESTED for probe/read/erase/write

Browse Source 
That is incorrect.

A bit of confusion comes from how the #defines are named. We call them
TEST_BAD_*, but the message printed by flashrom says: "This flash part
has status NOT WORKING for operations:"

Something that is unimplemented is definitely not working.

Neither of the chip entries mentioned above has erase or write functions
implemented, so erase and write are not working. Since their size is
unknown, we can't read them in. That means read is not working as well.
Probing is a different matter. If a chip-specific probe function had
matched, we wouldn't have to handle the chip with the "unknown xy SPI
chip" fallback. I'm tempted to call that "not working" as well, but I'm
open to discussion on this point.

Corresponding to flashrom svn r439 and coreboot v2 svn r4177.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
This commit is contained in:
Carl-Daniel Hailfinger 2009-04-22 13:33:43 +00:00
parent 691568bf2f
commit 42882fd97e
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
flashchips.c
View File

@ -2167,7 +2167,7 @@ struct flashchip flashchips[] = {
.model_id = GENERIC_DEVICE_ID,
.total_size = 0,
.page_size = 256,
.tested = TEST_UNTESTED,
.tested = TEST_BAD_PREW,
.probe = probe_spi_rdid,
.erase = NULL,
.write = NULL,
@ -2180,7 +2180,7 @@ struct flashchip flashchips[] = {
.model_id = GENERIC_DEVICE_ID,
.total_size = 0,
.page_size = 256,
.tested = TEST_UNTESTED,
.tested = TEST_BAD_PREW,
.probe = probe_spi_rdid,
.erase = NULL,
.write = NULL,
@ -2193,7 +2193,7 @@ struct flashchip flashchips[] = {
.model_id = GENERIC_DEVICE_ID,
.total_size = 0,
.page_size = 256,
.tested = TEST_UNTESTED,
.tested = TEST_BAD_PREW,
.probe = probe_spi_rdid,
.erase = NULL,
.write = NULL,
@ -2206,7 +2206,7 @@ struct flashchip flashchips[] = {
.model_id = GENERIC_DEVICE_ID,
.total_size = 0,
.page_size = 256,
.tested = TEST_UNTESTED,
.tested = TEST_BAD_PREW,
.probe = probe_spi_rdid,
.erase = NULL,
.write = NULL,
@ -2219,7 +2219,7 @@ struct flashchip flashchips[] = {
.model_id = GENERIC_DEVICE_ID,
.total_size = 0,
.page_size = 256,
.tested = TEST_UNTESTED,
.tested = TEST_BAD_PREW,
.probe = probe_spi_rdid,
.erase = NULL,
.write = NULL,
@ -2232,7 +2232,7 @@ struct flashchip flashchips[] = {
.model_id = GENERIC_DEVICE_ID,
.total_size = 0,
.page_size = 256,
.tested = TEST_UNTESTED,
.tested = TEST_BAD_PREW,
.probe = probe_spi_rdid,
.erase = NULL,
.write = NULL,