openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 07:02:34 +02:00
Code Issues Releases Wiki Activity

tree: Enable -Wwrite-strings

Browse Source 
When compiling, this warning gives string literals the type const char[]
to help catch accidental modification (which is undefined behaviour).
There currently aren't any instances of this in flashrom, so let's
enable this warning to keep it that way. This requires adding const
qualifiers to the declarations of several variables that work with
string literals.

Change-Id: I62d9bc194938a0c9a0e4cdff7ced8ea2e14cc1bc
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34577
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
This commit is contained in:
Jacob Garber 2019-07-25 19:12:31 -06:00 committed by Nico Huber
parent de77ad4678
commit 4a84ec273a
7 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -30,7 +30,7 @@ INSTALL = install
DIFF = diff
PREFIX ?= /usr/local
MANDIR ?= $(PREFIX)/share/man
CFLAGS ?= -Os -Wall -Wshadow -Wmissing-prototypes
CFLAGS ?= -Os -Wall -Wshadow -Wmissing-prototypes -Wwrite-strings
EXPORTDIR ?= .
RANLIB ?= ranlib
PKG_CONFIG ?= pkg-config

2
buspirate_spi.c
View File

@ -113,7 +113,7 @@ static int buspirate_sendrecv(unsigned char *buf, unsigned int writecnt,
return 0;
}
static int buspirate_wait_for_string(unsigned char *buf, char *key)
static int buspirate_wait_for_string(unsigned char *buf, const char *key)
{
unsigned int keylen = strlen(key);
int ret;

2
cli_classic.c
View File

@ -79,7 +79,7 @@ static void cli_classic_abort_usage(void)
exit(1);
}
static int check_filename(char *filename, char *type)
static int check_filename(char *filename, const char *type)
{
if (!filename || (filename[0] == '\0')) {
fprintf(stderr, "Error: No %s file specified.\n", type);

2
dmi.c
View File

@ -69,7 +69,7 @@ static struct {
static const struct {
uint8_t type;
uint8_t is_laptop;
char *name;
const char *name;
} dmi_chassis_types[] = {
{0x01, 2, "Other"},
{0x02, 2, "Unknown"},

3
meson.build
View File

@ -11,8 +11,9 @@ lt_revision = '0'
lt_age = '0'
lt_version = '@0@.@1@.@2@'.format(lt_current, lt_age, lt_revision)
# hide some warnings
# hide/enable some warnings
warning_flags = [
'-Wwrite-strings',
'-Wno-unused-parameter',
'-Wno-sign-compare',
'-Wno-address-of-packed-member',

2
pony_spi.c
View File

@ -115,7 +115,7 @@ int pony_spi_init(void)
int i, data_out;
char *arg = NULL;
enum pony_type type = TYPE_SI_PROG;
char *name;
const char *name;
int have_device = 0;
int have_prog = 0;

2
util/ich_descriptors_tool/ich_descriptors_tool.c
View File

@ -111,7 +111,7 @@ static void dump_files(const char *name, const uint32_t *buf, unsigned int len,
printf("\n");
}
static void usage(char *argv[], char *error)
static void usage(char *argv[], const char *error)
{
if (error != NULL) {
fprintf(stderr, "%s\n", error);