openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 22:43:17 +02:00
Code Issues Releases Wiki Activity

Introduce a type "chipaddr" to abstract the offsets within flash regions

Browse Source 
Use chipaddr instead of volatile uint8_t * because when we access chips
in external flashers, they are not accessed via pointers at all.

Benefits: This allows us to differentiate between volatile machine
memory accesses and flash chip accesses. It also enforces usage
of chip_{read,write}[bwl] to access flash chips, so nobody will
unintentionally use pointers to access chips anymore. Some unneeded
casts are removed as well. Grepping for chip operations and machine
memory operations doesn't yield any false positives anymore.

Compile tested on 32 bit and 64 bit Linux.

Corresponding to flashrom svn r519.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
This commit is contained in:
Carl-Daniel Hailfinger
2009-05-16 21:22:56 +00:00
parent 4059598a06
commit 5820f42ef2
23 changed files with 203 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
nic3com.c
View File

@ -87,17 +87,17 @@ void nic3com_unmap(void *virt_addr, size_t len)
{
}
void nic3com_chip_writeb(uint8_t val, volatile void *addr)
void nic3com_chip_writeb(uint8_t val, chipaddr addr)
{
OUTL((uint32_t)(intptr_t)addr, io_base_addr + BIOS_ROM_ADDR);
OUTL((uint32_t)addr, io_base_addr + BIOS_ROM_ADDR);
OUTB(val, io_base_addr + BIOS_ROM_DATA);
}
uint8_t nic3com_chip_readb(const volatile void *addr)
uint8_t nic3com_chip_readb(const chipaddr addr)
{
uint8_t val;
OUTL((uint32_t)(intptr_t)addr, io_base_addr + BIOS_ROM_ADDR);
OUTL((uint32_t)addr, io_base_addr + BIOS_ROM_ADDR);
val = INB(io_base_addr + BIOS_ROM_DATA);
return val;