openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 07:02:34 +02:00
Code Issues Releases Wiki Activity

realtek_mst_i2c_spi.c: Skip return value check for reset function

Browse Source 
The return value for reset function can not be guaranteed when
reset success. There is no way to check if reset success or not.

BUG=b:147402710,b:152558985
BRANCH=none
TEST=builds

Signed-off-by: Shiyu Sun <sshiyu@chromium.org>
Change-Id: Ia6200f7150db4368c26d8dfe779a9e85184b1b06
Reviewed-on: https://review.coreboot.org/c/flashrom/+/49786
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
This commit is contained in:
Shiyu Sun 2021-01-21 16:31:32 +11:00 committed by Edward O'Callaghan
parent dfded999cd
commit 5905270fc7
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
realtek_mst_i2c_spi.c
View File

@ -433,9 +433,13 @@ static int realtek_mst_i2c_spi_shutdown(void *data)
(struct realtek_mst_i2c_spi_data *)data;
int fd = realtek_mst_data->fd;
if (realtek_mst_data->reset) {
ret |= realtek_mst_i2c_spi_reset_mpu(fd);
if (ret != 0)
msg_perr("%s: MCU failed to reset on tear-down.\n", __func__);
/*
* Return value for reset mpu is not checked since
* the return value is not guaranteed to be 0 on a
* success reset. Currently there is no way to fix
* that. For more details see b:147402710.
*/
realtek_mst_i2c_spi_reset_mpu(fd);
}
i2c_close(fd);
free(data);